test: fix tests

Author: incendial

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_passing_async_when_sync_expected/avoid_passing_async_when_sync_expected_rule_test.dart

@@ -26,13 +26,18 @@ void main() {
 
       RuleTestHelper.verifyIssues(
         issues: issues,
-        startLines: [50, 55, 58, 101],
+        startLines: [49, 54, 57, 84],
         startColumns: [7, 7, 7, 9],
         locationTexts: [
-          'synchronousWork: work1,',
-          'synchronousWork3: () async {',
-          'synchronousWork4: work4,',
-          'onPressed: () async {',
+          'synchronousWork: work1',
+          'synchronousWork3: () async {\n'
+              "        print('work 3');\n"
+              '      }',
+          'synchronousWork4: work4',
+          'onPressed: () async {\n'
+              '          await Future.delayed(const Duration(seconds: 1));\n'
+              '          _incrementCounter();\n'
+              '        }',
         ],
         messages: [
           'Expected a sync function but got async.',

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_passing_async_when_sync_expected/examples/example.dart

@@ -1,29 +1,28 @@
-import 'package:flutter/material.dart';
+class Widget {}
 
-void main() {
-  runApp(const MyApp());
+class StatefulWidget extends Widget {}
+
+class FloatingActionButton extends Widget {
+  final VoidCallback onPressed;
+
+  const FloatingActionButton({required this.onPressed})
 }
 
-class MyApp extends StatelessWidget {
-  const MyApp({Key? key}) : super(key: key);
+class Scaffold extends Widget {
+  final Widget floatingActionButton;
 
-  @override
-  Widget build(BuildContext context) {
-    return MaterialApp(
-      title: 'Flutter Demo',
-      theme: ThemeData(
-        primarySwatch: Colors.blue,
-      ),
-      home: const MyHomePage(title: 'Flutter Demo Home Page'),
-    );
-  }
+  const Scaffold({required this.floatingActionButton});
 }
 
-class MyHomePage extends StatefulWidget {
-  const MyHomePage({Key? key, required this.title}) : super(key: key);
+typedef VoidCallback = void Function();
+
+abstract class State<T> {
+  void initState();
 
-  final String title;
+  void setState(VoidCallback callback) => callback();
+}
 
+class MyHomePage extends StatefulWidget {
   @override
   State<MyHomePage> createState() => _MyHomePageState();
 }
@@ -55,7 +54,7 @@ class _MyHomePageState extends State<MyHomePage> {
       synchronousWork3: () async {
         print('work 3');
       },
-      synchronousWork4: work4,
+      synchronousWork4: work4, // LINT
     );
   }
 
@@ -80,30 +79,12 @@ class _MyHomePageState extends State<MyHomePage> {
   @override
   Widget build(BuildContext context) {
     return Scaffold(
-      appBar: AppBar(
-        title: Text(widget.title),
-      ),
-      body: Center(
-        child: Column(
-          mainAxisAlignment: MainAxisAlignment.center,
-          children: <Widget>[
-            const Text(
-              'You have pushed the button this many times:',
-            ),
-            Text(
-              '$_counter',
-              style: Theme.of(context).textTheme.headline4,
-            ),
-          ],
-        ),
-      ),
       floatingActionButton: FloatingActionButton(
+        // LINT
         onPressed: () async {
           await Future.delayed(const Duration(seconds: 1));
           _incrementCounter();
         },
-        tooltip: 'Increment',
-        child: const Icon(Icons.add),
       ),
     );
   }

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/examples/not_named_parameter_example.dart

@@ -39,20 +39,20 @@ class Scaffold extends Widget {
 class CustomScrollView extends Widget {
   final Iterable<Widget> slivers;
 
-  const CustomScrollView({@required this.slivers});
+  const CustomScrollView({required this.slivers});
 }
 
 class SliverGrid extends Widget {
   final Widget delegate;
 
-  const SliverGrid({@required this.delegate});
+  const SliverGrid({required this.delegate});
 }
 
 class SliverChildBuilderDelegate extends Widget {
   final int childCount;
   final WidgetBuilder builder;
 
-  const SliverChildBuilderDelegate(this.builder, {@required this.childCount});
+  const SliverChildBuilderDelegate(this.builder, {required this.childCount});
 }
 
 typedef WidgetBuilder = Widget Function(BuildContext context);