feat: cleanup public API (#1053)

Author: incendial

CHANGELOG.md

@@ -10,6 +10,7 @@
 * feat: support dynamic method names for [`member-ordering`](https://dartcodemetrics.dev/docs/rules/common/member-ordering).
 * fix: check `of` constructor exist for [`prefer-iterable-of`](https://dartcodemetrics.dev/docs/rules/common/prefer-iterable-of)
 * feat: **Breaking change** change severity for avoid-banned-imports, prefer-trailing-comma, ban-name rules.
+* feat: **Breaking change** cleanup public API.
 
 ## 4.21.2
 

lib/cli_runner.dart

@@ -1 +1,3 @@
 export 'package:dart_code_metrics/src/cli/cli_runner.dart';
+export 'package:dart_code_metrics/src/logger/logger.dart';
+export 'package:dart_code_metrics/src/logger/progress.dart';

lib/src/analyzers/lint_analyzer/anti_patterns/anti_patterns_list/long_method.dart

@@ -8,7 +8,6 @@ import '../../../../utils/node_utils.dart';
 import '../../lint_utils.dart';
 import '../../metrics/metric_utils.dart';
 import '../../metrics/metrics_list/source_lines_of_code/source_lines_of_code_metric.dart';
-import '../../metrics/models/metric_value_level.dart';
 import '../../models/entity_type.dart';
 import '../../models/internal_resolved_unit_result.dart';
 import '../../models/issue.dart';
@@ -74,9 +73,6 @@ class LongMethod extends Pattern {
                           ),
                         ),
                       ),
-                if (_sourceLinesOfCodeMetricThreshold == null)
-                  // ignore: deprecated_member_use_from_same_package
-                  ..._legacyBehaviour(source, entry),
               ])
           .toList();
 
@@ -109,30 +105,4 @@ class LongMethod extends Pattern {
       maximumLines != null
           ? "Based on configuration of this package, we don't recommend write a $functionType longer than $maximumLines lines with code."
           : null;
-
-  @Deprecated('Fallback for current behaviour, will be removed in 5.0.0')
-  Iterable<Issue> _legacyBehaviour(
-    InternalResolvedUnitResult source,
-    MapEntry<ScopedFunctionDeclaration, Report> entry,
-  ) =>
-      entry.value.metrics
-          .where((metricValue) =>
-              metricValue.metricsId == SourceLinesOfCodeMetric.metricId &&
-              metricValue.level == MetricValueLevel.none &&
-              metricValue.value > 50)
-          .map(
-            (metricValue) => createIssue(
-              pattern: this,
-              location: nodeLocation(
-                node: entry.key.declaration,
-                source: source,
-              ),
-              message: _compileMessage(
-                lines: metricValue.value,
-                functionType: entry.key.type,
-              ),
-              verboseMessage:
-                  'Anti pattern works in deprecated mode. Please configure ${SourceLinesOfCodeMetric.metricId} metric. For detailed information please read documentation.',
-            ),
-          );
 }

lib/src/analyzers/lint_analyzer/anti_patterns/anti_patterns_list/long_parameter_list.dart

@@ -4,7 +4,6 @@ import '../../../../utils/node_utils.dart';
 import '../../lint_utils.dart';
 import '../../metrics/metric_utils.dart';
 import '../../metrics/metrics_list/number_of_parameters_metric.dart';
-import '../../metrics/models/metric_value_level.dart';
 import '../../models/entity_type.dart';
 import '../../models/function_type.dart';
 import '../../models/internal_resolved_unit_result.dart';
@@ -72,9 +71,6 @@ class LongParameterList extends Pattern {
                           ),
                         ),
                       ),
-                if (_numberOfParametersMetricThreshold == null)
-                  // ignore: deprecated_member_use_from_same_package
-                  ..._legacyBehaviour(source, entry),
               ])
           .toList();
 
@@ -91,30 +87,4 @@ class LongParameterList extends Pattern {
       maximumArguments != null
           ? "Based on configuration of this package, we don't recommend writing a $functionType with argument count more than $maximumArguments."
           : null;
-
-  @Deprecated('Fallback for current behaviour, will be removed in 5.0.0')
-  Iterable<Issue> _legacyBehaviour(
-    InternalResolvedUnitResult source,
-    MapEntry<ScopedFunctionDeclaration, Report> entry,
-  ) =>
-      entry.value.metrics
-          .where((metricValue) =>
-              metricValue.metricsId == NumberOfParametersMetric.metricId &&
-              metricValue.level == MetricValueLevel.none &&
-              metricValue.value > 4)
-          .map(
-            (metricValue) => createIssue(
-              pattern: this,
-              location: nodeLocation(
-                node: entry.key.declaration,
-                source: source,
-              ),
-              message: _compileMessage(
-                args: metricValue.value,
-                functionType: entry.key.type,
-              ),
-              verboseMessage:
-                  'Anti pattern works in deprecated mode. Please configure ${NumberOfParametersMetric.metricId} metric. For detailed information please read documentation.',
-            ),
-          );
 }

lib/src/analyzers/lint_analyzer/lint_analyzer.dart

@@ -38,12 +38,10 @@ class LintAnalyzer {
 
   /// Returns a reporter for the given [name]. Use the reporter
   /// to convert analysis reports to console, JSON or other supported format.
-  Reporter<FileReport, Object, LintReportParams>? getReporter({
+  Reporter<FileReport, LintReportParams>? getReporter({
     required String name,
     required IOSink output,
     required String reportFolder,
-    @Deprecated('Unused argument. Will be removed in 5.0.0.') // ignore: avoid-unused-parameters
-        LintConfig? config,
   }) =>
       reporter(
         name: name,

lib/src/analyzers/lint_analyzer/models/summary_lint_report_record_status.dart

@@ -3,19 +3,19 @@ class SummaryLintReportRecordStatus {
   /// Error.
   ///
   /// Status indicates that a record contains error information.
-  /// Commonly represend by ❌ emoji
+  /// Commonly represented by ❌ emoji
   static const error = SummaryLintReportRecordStatus._('error');
 
   /// Warning.
   ///
   /// Status indicates that a record requires user attention.
-  /// Commonly represend by ⚠️ emoji.
+  /// Commonly represented by ⚠️ emoji.
   static const warning = SummaryLintReportRecordStatus._('warning');
 
   /// OK.
   ///
   /// Standard status for successful record.
-  /// Commonly represend by ✅ emoji.
+  /// Commonly represented by ✅ emoji.
   static const ok = SummaryLintReportRecordStatus._('ok');
 
   /// None.

lib/src/analyzers/lint_analyzer/reporters/lint_report_params.dart

@@ -1,6 +1,9 @@
+import '../models/summary_lint_report_record.dart';
+
 /// Represents additional lint reporter params.
 class LintReportParams {
   final bool congratulate;
+  final Iterable<SummaryLintReportRecord<Object>> summary;
 
-  const LintReportParams({required this.congratulate});
+  const LintReportParams({required this.congratulate, required this.summary});
 }

lib/src/analyzers/lint_analyzer/reporters/reporter_factory.dart

@@ -18,7 +18,7 @@ import 'reporters_list/json/lint_json_reporter.dart';
 
 final _implementedReports = <
     String,
-    Reporter<FileReport, Object, LintReportParams> Function(
+    Reporter<FileReport, LintReportParams> Function(
   IOSink output,
   String reportFolder,
 )>{
@@ -34,7 +34,7 @@ final _implementedReports = <
       LintCodeClimateReporter(output, gitlabCompatible: true),
 };
 
-Reporter<FileReport, Object, LintReportParams>? reporter({
+Reporter<FileReport, LintReportParams>? reporter({
   required String name,
   required IOSink output,
   required String reportFolder,

lib/src/analyzers/lint_analyzer/reporters/reporters_list/checkstyle/lint_checkstyle_reporter.dart

@@ -4,20 +4,18 @@ import '../../../../../reporters/models/checkstyle_reporter.dart';
 import '../../../metrics/models/metric_value_level.dart';
 import '../../../models/lint_file_report.dart';
 import '../../../models/severity.dart';
-import '../../../models/summary_lint_report_record.dart';
 import '../../lint_report_params.dart';
 
 /// Lint Checkstyle reporter.
 ///
 /// Use it to create reports in Checkstyle format.
-class LintCheckstyleReporter extends CheckstyleReporter<LintFileReport,
-    SummaryLintReportRecord<Object>, LintReportParams> {
+class LintCheckstyleReporter
+    extends CheckstyleReporter<LintFileReport, LintReportParams> {
   LintCheckstyleReporter(super.output);
 
   @override
   Future<void> report(
     Iterable<LintFileReport> records, {
-    Iterable<SummaryLintReportRecord<Object>> summary = const [],
     LintReportParams? additionalParams,
   }) async {
     if (records.isEmpty) {

lib/src/analyzers/lint_analyzer/reporters/reporters_list/code_climate/lint_code_climate_reporter.dart

@@ -8,7 +8,6 @@ import '../../../models/issue.dart';
 import '../../../models/lint_file_report.dart';
 import '../../../models/report.dart';
 import '../../../models/severity.dart';
-import '../../../models/summary_lint_report_record.dart';
 import '../../lint_report_params.dart';
 import 'models/code_climate_issue.dart';
 import 'models/code_climate_issue_category.dart';
@@ -18,14 +17,13 @@ import 'models/code_climate_issue_severity.dart';
 /// Lint Code Climate reporter.
 ///
 /// Use it to create reports in Code Climate format.
-class LintCodeClimateReporter extends CodeClimateReporter<LintFileReport,
-    SummaryLintReportRecord<Object>, LintReportParams> {
+class LintCodeClimateReporter
+    extends CodeClimateReporter<LintFileReport, LintReportParams> {
   LintCodeClimateReporter(super.output, {super.gitlabCompatible});
 
   @override
   Future<void> report(
     Iterable<LintFileReport> records, {
-    Iterable<SummaryLintReportRecord<Object>> summary = const [],
     LintReportParams? additionalParams,
   }) async {
     if (records.isEmpty) {