chore: review cleanup

Author: incendial

CHANGELOG.md

@@ -8,6 +8,7 @@
 * fix: improve context root included files calculation.
 * feat: add [`avoid-banned-imports`](https://dartcodemetrics.dev/docs/rules/common/avoid-banned-imports) rule
 * fix: resolve package with imported analysis options.
+* feat: add configuration to [`prefer-extracting-callbacks`](https://dartcodemetrics.dev/docs/rules/flutter/prefer-extracting-callbacks)
 
 ## 4.15.2
 

dart_dependency_validator.yaml

@@ -2,3 +2,4 @@ ignore:
   - analyzer
   - intl
   - test_lints
+  - flutter

lib/src/analyzers/lint_analyzer/metrics/metrics_list/source_lines_of_code/source_code_visitor.dart renamed to lib/src/analyzers/lint_analyzer/base_visitors/source_code_visitor.dart

@@ -1,6 +1,7 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:source_span/source_span.dart';
 
+import '../../../base_visitors/source_code_visitor.dart';
 import '../../../models/context_message.dart';
 import '../../../models/entity_type.dart';
 import '../../../models/internal_resolved_unit_result.dart';
@@ -11,7 +12,6 @@ import '../../models/function_metric.dart';
 import '../../models/metric_computation_result.dart';
 import '../../models/metric_documentation.dart';
 import '../../models/metric_value.dart';
-import 'source_code_visitor.dart';
 
 const _documentation = MetricDocumentation(
   name: 'Source lines of Code',

lib/src/analyzers/lint_analyzer/metrics/metrics_list/source_lines_of_code/source_lines_of_code_metric.dart

@@ -2,11 +2,12 @@
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/source/line_info.dart';
 
 import '../../../../../utils/flutter_types_utils.dart';
 import '../../../../../utils/node_utils.dart';
+import '../../../base_visitors/source_code_visitor.dart';
 import '../../../lint_utils.dart';
-import '../../../metrics/metrics_list/source_lines_of_code/source_code_visitor.dart';
 import '../../../models/internal_resolved_unit_result.dart';
 import '../../../models/issue.dart';
 import '../../../models/severity.dart';
@@ -36,7 +37,8 @@ class PreferExtractingCallbacksRule extends FlutterRule {
 
   @override
   Iterable<Issue> check(InternalResolvedUnitResult source) {
-    final visitor = _Visitor(source, _ignoredArguments, _allowedLineCount);
+    final visitor =
+        _Visitor(source.lineInfo, _ignoredArguments, _allowedLineCount);
 
     source.unit.visitChildren(visitor);
 

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/prefer_extracting_callbacks_rule.dart

@@ -3,13 +3,13 @@ part of 'prefer_extracting_callbacks_rule.dart';
 class _Visitor extends SimpleAstVisitor<void> {
   final _expressions = <Expression>[];
 
-  final InternalResolvedUnitResult _source;
+  final LineInfo _lineInfo;
   final Iterable<String> _ignoredArguments;
   final int? _allowedLineCount;
 
   Iterable<Expression> get expressions => _expressions;
 
-  _Visitor(this._source, this._ignoredArguments, this._allowedLineCount);
+  _Visitor(this._lineInfo, this._ignoredArguments, this._allowedLineCount);
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
@@ -19,8 +19,11 @@ class _Visitor extends SimpleAstVisitor<void> {
       return;
     }
 
-    final visitor =
-        _InstanceCreationVisitor(_source, _ignoredArguments, _allowedLineCount);
+    final visitor = _InstanceCreationVisitor(
+      _lineInfo,
+      _ignoredArguments,
+      _allowedLineCount,
+    );
     node.visitChildren(visitor);
 
     _expressions.addAll(visitor.expressions);
@@ -30,14 +33,17 @@ class _Visitor extends SimpleAstVisitor<void> {
 class _InstanceCreationVisitor extends RecursiveAstVisitor<void> {
   final _expressions = <Expression>[];
 
-  final InternalResolvedUnitResult _source;
+  final LineInfo _lineInfo;
   final Iterable<String> _ignoredArguments;
   final int? _allowedLineCount;
 
   Iterable<Expression> get expressions => _expressions;
 
   _InstanceCreationVisitor(
-      this._source, this._ignoredArguments, this._allowedLineCount);
+    this._lineInfo,
+    this._ignoredArguments,
+    this._allowedLineCount,
+  );
 
   @override
   void visitInstanceCreationExpression(InstanceCreationExpression node) {
@@ -88,7 +94,7 @@ class _InstanceCreationVisitor extends RecursiveAstVisitor<void> {
       return true;
     }
 
-    final visitor = SourceCodeVisitor(_source.lineInfo);
+    final visitor = SourceCodeVisitor(_lineInfo);
     expression.visitChildren(visitor);
 
     return visitor.linesWithCode.length > allowedLineCount;

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/visitor.dart

@@ -1,4 +1,4 @@
-import 'package:dart_code_metrics/src/analyzers/lint_analyzer/metrics/metrics_list/source_lines_of_code/source_code_visitor.dart';
+import 'package:dart_code_metrics/src/analyzers/lint_analyzer/base_visitors/source_code_visitor.dart';
 import 'package:dart_code_metrics/src/analyzers/lint_analyzer/metrics/scope_visitor.dart';
 import 'package:test/test.dart';