fix: fix regression in is! checks for avoid-unnecessary-type-assertions

Author: incendial

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 4.18.1
+
+* fix: fix regression in is! checks for [`avoid-unnecessary-type-assertions`](https://dartcodemetrics.dev/docs/rules/common/avoid-unnecessary-type-assertions).
+* chore: restrict `analyzer` version to `>=4.4.0 <4.8.0`.
+
 ## 4.18.0
 
 * feat: support passing file paths to all commands.

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_assertions/visitor.dart

@@ -44,7 +44,10 @@ class _Visitor extends RecursiveAstVisitor<void> {
     final castedType = node.type.type;
 
     if (node.notOperator != null) {
-      if (_isUselessTypeCheck(castedType, objectType, true)) {
+      if (objectType != null &&
+          !objectType.isDynamic &&
+          !objectType.isDartCoreObject &&
+          _isUselessTypeCheck(castedType, objectType, true)) {
         _expressions[node] =
             '${node.isOperator.keyword?.lexeme ?? ''}${node.notOperator ?? ''}';
       }

pubspec.yaml

@@ -10,8 +10,8 @@ environment:
   sdk: ">=2.17.0 <3.0.0"
 
 dependencies:
-  analyzer: ">=4.1.0 <4.8.0"
-  analyzer_plugin: ">=0.11.0 <0.12.0"
+  analyzer: ">=4.3.0 <4.8.0"
+  analyzer_plugin: ">=0.11.1 <0.12.0"
   ansicolor: ^2.0.1
   args: ^2.0.0
   collection: ^1.15.0

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_type_assertions/examples/example_with_not_is.dart

@@ -11,12 +11,18 @@ class Cat extends HomeAnimal {}
 void checkSameOrInheritor() {
   final cat = Cat();
 
-  final check = cat is! Cat; // Lint
+  final check = cat is! Cat; // LINT
   final check = cat is Dog;
   final check = cat is! Dog; // LINT
-  final check = cat is! NotAnimal; // Lint
+  final check = cat is! NotAnimal; // LINT
 
   final Cat? nullableCat = null;
 
   final check = nullableCat is! Cat;
+
+  final dynamic a;
+  final check = a is! int;
+
+  final Object b;
+  final check = b is! int;
 }