chore: migrate on analyzer 2.5.0 (#483)

* chore: migrate on analyzer 2.5.0 and analyzer_plugin 0.8.0

* ref: update imports

Author: dkrutskikh

.github/workflows/build.yaml

@@ -44,14 +44,14 @@ jobs:
           bash <(curl -s https://codecov.io/bash) -f coverage/coverage.lcov
 
   minimal-dart:
-    name: Build on minimal supported 2.12 dart
+    name: Build on minimal supported 2.14 dart
 
     runs-on: ubuntu-latest
 
     steps:
       - uses: dart-lang/setup-dart@v1
         with:
-          sdk: "2.12.4"
+          sdk: "2.14.0"
       - uses: actions/checkout@v2
       - name: Install dependencies
         run: pub downgrade

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+* chore: changed min `SDK` version to `2.14.0`.
+* chore: restrict `analyzer` version to `>=2.4.0 <2.6.0`.
+* chore: changed the supported `analyzer_plugin` version to `^0.8.0`.
+
 ## 4.4.0
 
 * feat: introduce `check-unused-l10n` command.

lib/src/analyzers/lint_analyzer/rules/base_visitors/intl_base_visitor.dart

@@ -33,7 +33,7 @@ abstract class IntlBaseVisitor extends GeneralizingAstVisitor<void> {
 
   @override
   void visitFieldDeclaration(FieldDeclaration node) {
-    if (node.fields.type?.as<TypeName>()?.name.name != 'String') {
+    if (node.fields.type?.as<NamedType>()?.name.name != 'String') {
       return;
     }
 

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_returning_widgets/visitor.dart

@@ -36,7 +36,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
-    final classType = node.extendsClause?.superclass.type;
+    final classType = node.extendsClause?.superclass2.type;
     if (!isWidgetOrSubclass(classType) && !isWidgetStateOrSubclass(classType)) {
       return;
     }

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unnecessary_setstate/visitor.dart

@@ -14,7 +14,7 @@ class _Visitor extends RecursiveAstVisitor<void> {
   void visitClassDeclaration(ClassDeclaration node) {
     super.visitClassDeclaration(node);
 
-    final type = node.extendsClause?.superclass.type;
+    final type = node.extendsClause?.superclass2.type;
     if (type == null || !isWidgetStateOrSubclass(type)) {
       return;
     }

lib/src/analyzers/lint_analyzer/rules/rules_list/no_object_declaration/visitor.dart

@@ -25,5 +25,5 @@ class _Visitor extends RecursiveAstVisitor<void> {
 
   bool _hasObjectType(TypeAnnotation? type) =>
       type?.type?.isDartCoreObject ??
-      (type is TypeName && type.name.name == 'Object');
+      (type is NamedType && type.name.name == 'Object');
 }

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_extracting_callbacks/visitor.dart

@@ -11,7 +11,7 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   @override
   void visitClassDeclaration(ClassDeclaration node) {
-    final classType = node.extendsClause?.superclass.type;
+    final classType = node.extendsClause?.superclass2.type;
     if (!isWidgetOrSubclass(classType) && !isWidgetStateOrSubclass(classType)) {
       return;
     }

lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_single_widget_per_file/visitor.dart

@@ -15,7 +15,7 @@ class _Visitor extends SimpleAstVisitor<void> {
   void visitClassDeclaration(ClassDeclaration node) {
     super.visitClassDeclaration(node);
 
-    final classType = node.extendsClause?.superclass.type;
+    final classType = node.extendsClause?.superclass2.type;
     if (isWidgetOrSubclass(classType) &&
         (!_ignorePrivateWidgets || !Identifier.isPrivateName(node.name.name))) {
       _nodes.add(node);

pubspec.yaml

@@ -7,11 +7,11 @@ issue_tracker: https://github.com/dart-code-checker/dart-code-metrics/issues
 documentation: https://dartcodemetrics.dev/docs/getting-started/introduction
 
 environment:
-  sdk: ">=2.12.0 <3.0.0"
+  sdk: ">=2.14.0 <3.0.0"
 
 dependencies:
-  analyzer: '>=2.1.0 <2.4.0'
-  analyzer_plugin: ^0.7.0
+  analyzer: '>=2.4.0 <2.6.0'
+  analyzer_plugin: ^0.8.0
   ansicolor: ^2.0.1
   args: ^2.0.0
   collection: ^1.15.0

test/analyzer_plugin/analyzer_plugin_utils_test.dart

@@ -3,9 +3,9 @@ import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/element/element.dart';
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer_plugin/protocol/protocol_common.dart';
-import 'package:dart_code_metrics/lint_analyzer.dart';
 import 'package:dart_code_metrics/src/analyzer_plugin/analyzer_plugin_utils.dart';
 import 'package:dart_code_metrics/src/analyzers/lint_analyzer/models/issue.dart';
+import 'package:dart_code_metrics/src/analyzers/lint_analyzer/models/replacement.dart';
 import 'package:dart_code_metrics/src/analyzers/lint_analyzer/models/severity.dart';
 import 'package:mocktail/mocktail.dart';
 import 'package:source_span/source_span.dart';