fix: update tear-off detection for unused-parameters rule

Author: incendial

lib/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/visitor.dart

@@ -113,7 +113,7 @@ class _InvocationsVisitor extends RecursiveAstVisitor<void> {
   void visitSimpleIdentifier(SimpleIdentifier node) {
     if (node.name == methodName &&
         node.staticElement is MethodElement &&
-        node.parent! is MethodInvocation) {
+        node.parent is ArgumentList) {
       hasTearOffInvocations = true;
     }
 

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/avoid_unused_parameters_rule_test.dart

@@ -70,17 +70,21 @@ void main() {
 
       RuleTestHelper.verifyIssues(
         issues: issues,
-        startLines: [8, 13, 13],
-        startColumns: [36, 23, 43],
+        startLines: [13, 13, 21, 25, 26],
+        startColumns: [23, 43, 25, 5, 5],
         locationTexts: [
-          'int value',
           'String firstString',
           'String secondString',
+          'String value',
+          'int value',
+          'String name',
         ],
         messages: [
           'Parameter is unused.',
           'Parameter is unused.',
           'Parameter is unused.',
+          'Parameter is unused.',
+          'Parameter is unused.',
         ],
       );
     });

test/src/analyzers/lint_analyzer/rules/rules_list/avoid_unused_parameters/examples/tear_off_example.dart

@@ -13,8 +13,18 @@ class TestClass {
   void _anotherMethod(String firstString, String secondString) {
     someMethod(_otherMethod);
     _someOtherMethod(value);
+
+    final replacement = value.isNotEmpty ? _someAnotherMethod(1, '1') : null;
   }
 
   // LINT
-  _someOtherMethod(String value) {}
+  void _someOtherMethod(String value) {}
+
+  // LINT
+  String _someAnotherMethod(
+    int value,
+    String name,
+  ) {
+    return '';
+  }
 }