fix: skip synthetic tokens while compute 'Source lines of Code' (#487)

* fix: skip synthetic tokens while compute 'Source lines of Code'

* chore: revert experimental code

Author: dkrutskikh

CHANGELOG.md

@@ -7,6 +7,7 @@
 * feat: improve static code diagnostic `prefer-extracting-callbacks`: don't trigger on empty function blocks and ignore Flutter builder functions.
 * feat: improve unused files check, add support for `vm:entry-point` annotation.
 * fix: compute NumberOfParametersMetric only for functions and methods.
+* fix: skip synthetic tokens while compute 'Source lines of Code'.
 
 ## 4.3.3
 

lib/src/analyzers/lint_analyzer/metrics/metrics_factory.dart

@@ -33,14 +33,10 @@ final _implementedMetrics = <String, Metric Function(Map<String, Object>)>{
 
 Iterable<Metric> getMetrics({
   required Map<String, Object> config,
-  Iterable<String> patternsDependencies = const [],
   EntityType? measuredType,
 }) {
-  final _metrics = _implementedMetrics.keys.map(
-    (id) => _implementedMetrics[id]!(
-      !patternsDependencies.contains(id) ? config : {},
-    ),
-  );
+  final _metrics =
+      _implementedMetrics.keys.map((id) => _implementedMetrics[id]!(config));
 
   return measuredType != null
       ? _metrics

lib/src/analyzers/lint_analyzer/metrics/metrics_list/source_lines_of_code/source_code_visitor.dart

@@ -35,7 +35,10 @@ class SourceCodeVisitor extends RecursiveAstVisitor<void> {
   void _collectFunctionBodyData(Token? firstToken, Token? lastToken) {
     var token = firstToken;
     while (token != lastToken && token != null) {
-      _linesWithCode.add(_lineInfo.getLocation(token.offset).lineNumber);
+      if (!token.isSynthetic) {
+        _linesWithCode.add(_lineInfo.getLocation(token.offset).lineNumber);
+      }
+
       token = token.next;
     }
   }

lib/src/config_builder/config_builder.dart

@@ -25,35 +25,26 @@ class ConfigBuilder {
     String excludesRootFolder, {
     Iterable<Metric<num>>? classMetrics,
     Iterable<Metric<num>>? functionMetrics,
-  }) {
-    final patterns = getPatternsById(config);
-    final patternsDependencies = patterns
-        .map((pattern) => pattern.dependentMetricIds)
-        .expand((e) => e)
-        .toSet();
-
-    return LintAnalysisConfig(
-      prepareExcludes(config.excludePatterns, excludesRootFolder),
-      getRulesById(config.rules),
-      prepareExcludes(config.excludeForRulesPatterns, excludesRootFolder),
-      patterns,
-      classMetrics ??
-          getMetrics(
-            config: config.metrics,
-            patternsDependencies: patternsDependencies,
-            measuredType: EntityType.classEntity,
-          ),
-      functionMetrics ??
-          getMetrics(
-            config: config.metrics,
-            patternsDependencies: patternsDependencies,
-            measuredType: EntityType.methodEntity,
-          ),
-      prepareExcludes(config.excludeForMetricsPatterns, excludesRootFolder),
-      config.metrics,
-      excludesRootFolder,
-    );
-  }
+  }) =>
+      LintAnalysisConfig(
+        prepareExcludes(config.excludePatterns, excludesRootFolder),
+        getRulesById(config.rules),
+        prepareExcludes(config.excludeForRulesPatterns, excludesRootFolder),
+        getPatternsById(config),
+        classMetrics ??
+            getMetrics(
+              config: config.metrics,
+              measuredType: EntityType.classEntity,
+            ),
+        functionMetrics ??
+            getMetrics(
+              config: config.metrics,
+              measuredType: EntityType.methodEntity,
+            ),
+        prepareExcludes(config.excludeForMetricsPatterns, excludesRootFolder),
+        config.metrics,
+        excludesRootFolder,
+      );
 
   static UnusedFilesConfig getUnusedFilesConfigFromArgs(
     Iterable<String> excludePatterns,