#234: Fixed PHPStan issues

Author: raymondschouten

composer.json

@@ -18,6 +18,9 @@
         "darkwebdesign/symfony-addon-transformers": "6.0.*",
         "doctrine/orm": "^2.7",
         "phpstan/phpstan": "^1.11",
+        "phpstan/phpstan-doctrine": "^1.4",
+        "phpstan/phpstan-phpunit": "^1.4",
+        "phpstan/phpstan-symfony": "^1.4",
         "phpunit/phpunit": "^9.5",
         "rector/rector": "^1.1"
     },

phpstan.neon

@@ -1,5 +1,11 @@
+includes:
+    - 'vendor/phpstan/phpstan-doctrine/extension.neon'
+    - 'vendor/phpstan/phpstan-phpunit/extension.neon'
+    - 'vendor/phpstan/phpstan-symfony/extension.neon'
+
 parameters:
-    level: 1
+    level: 8
+
     paths:
-        - src
-        - tests
+        - 'src'
+        - 'tests'

rector.php

@@ -16,6 +16,5 @@
         SymfonySetList::SYMFONY_60,
     ])
     ->withImportNames(
-        importDocBlockNames: false,
         importShortClasses: false,
     );

src/BirthdayType.php

@@ -27,27 +27,19 @@
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
- * Birthday form field type.
- *
  * @author Raymond Schouten
  *
  * @since 2.3
  */
 class BirthdayType extends AbstractType
 {
-    /**
-     * Configures the options for this type.
-     */
     public function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([
             'years' => range(date('Y'), date('Y') - 120),
         ]);
     }
 
-    /**
-     * Returns the name of the parent type.
-     */
     public function getParent(): string
     {
         return DateType::class;

src/BooleanToYesNoSubscriber.php

@@ -27,8 +27,6 @@
 use Symfony\Component\Form\FormEvents;
 
 /**
- * Boolean to "yes" or "no" form event subscriber.
- *
  * @author Raymond Schouten
  *
  * @since 5.2.1
@@ -63,9 +61,6 @@ public function onPreSubmit(FormEvent $event): void
         $event->setData($data);
     }
 
-    /**
-     * Returns an array of event names this subscriber wants to listen to.
-     */
     public static function getSubscribedEvents(): array
     {
         return [

src/BooleanType.php

@@ -30,17 +30,12 @@
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
- * Boolean form field type.
- *
  * @author Raymond Schouten
  *
  * @since 2.3
  */
 class BooleanType extends AbstractType
 {
-    /**
-     * Builds the form.
-     */
     public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         if (!class_exists(BooleanToValueTransformer::class)) {
@@ -50,9 +45,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
         $builder->addModelTransformer(new BooleanToValueTransformer($options['value_true'], $options['value_false']));
     }
 
-    /**
-     * Configures the options for this type.
-     */
     public function configureOptions(OptionsResolver $resolver): void
     {
         $labelTrueNormalizer = fn(Options $options, $value) =>
@@ -92,9 +84,6 @@ public function configureOptions(OptionsResolver $resolver): void
         $resolver->setAllowedValues('widget', ['choice', 'radio']);
     }
 
-    /**
-     * Returns the name of the parent type.
-     */
     public function getParent(): string
     {
         return ChoiceType::class;
@@ -105,6 +94,6 @@ public function getParent(): string
      */
     public function humanize(string $text): string
     {
-        return ucfirst(trim(strtolower(preg_replace(['/([A-Z])/', '/[_\s]+/'], ['_$1', ' '], $text))));
+        return ucfirst(trim(strtolower((string) preg_replace(['/([A-Z])/', '/[_\s]+/'], ['_$1', ' '], $text))));
     }
 }

src/EntityType.php

@@ -38,8 +38,6 @@
 // @codeCoverageIgnoreEnd
 
 /**
- * Entity form field type.
- *
  * @author Raymond Schouten
  *
  * @since 2.3
@@ -51,9 +49,6 @@ public function __construct(
     ) {
     }
 
-    /**
-     * Builds the form.
-     */
     public function buildForm(FormBuilderInterface $builder, array $options): void
     {
         if (!class_exists(EntityToIdentifierTransformer::class)) {
@@ -63,9 +58,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
         $builder->addViewTransformer(new EntityToIdentifierTransformer($options['entity_manager'], $options['class']));
     }
 
-    /**
-     * Configures the options for this type.
-     */
     public function configureOptions(OptionsResolver $resolver): void
     {
         if (!interface_exists(ObjectManager::class)) {

src/JsonSchemaSubscriber.php

@@ -27,8 +27,6 @@
 use Symfony\Component\Form\FormEvents;
 
 /**
- * JSON Schema form event subscriber.
- *
  * @author Raymond Schouten
  *
  * @since 5.2.1
@@ -57,9 +55,6 @@ public function onPreSubmit(FormEvent $event): void
         $event->setData($data);
     }
 
-    /**
-     * Returns an array of event names this subscriber wants to listen to.
-     */
     public static function getSubscribedEvents(): array
     {
         return [

src/UnstructuredType.php

@@ -26,17 +26,12 @@
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 /**
- * Unstructured form field type.
- *
  * @author Raymond Schouten
  *
  * @since 3.4
  */
 class UnstructuredType extends AbstractType
 {
-    /**
-     * Configures the options for this type.
-     */
     public function configureOptions(OptionsResolver $resolver): void
     {
         $compoundNormalizer = fn() => false;

tests/BooleanToYesNoSubscriberTest.php

@@ -78,6 +78,9 @@ public function testDataNotArray(): void
         $this->assertNull($form->get('isActive')->getData());
     }
 
+    /**
+     * @return array<string, array{bool|null}>
+     */
     public function provider(): array
     {
         return [