Skip to content

Commit cedaebc

Browse files
artur-ciocanuArtur Ciocanu
andauthored
Ensure we use the same GRPC version everywhere (#1137)
* Ensure we use the same GRPC version everywhere Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Fix actors tests assert Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Revert Dapr exception asserts Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Increase sleep to allow Spring Context to bootstrap Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Revert sleep value Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Increase the sleep for messaging test Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Move sleep before each, to ensure Spring context starts Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> * Add more delays to ensure Spring Controller gets the messages Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> --------- Signed-off-by: Artur Ciocanu <ciocanu@adobe.com> Co-authored-by: Artur Ciocanu <ciocanu@adobe.com>
1 parent 436b7df commit cedaebc

File tree

6 files changed

+11
-9
lines changed

6 files changed

+11
-9
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,13 +104,13 @@
104104
<dependency>
105105
<groupId>io.grpc</groupId>
106106
<artifactId>grpc-testing</artifactId>
107-
<version>1.56.1</version>
107+
<version>${grpc.version}</version>
108108
<scope>test</scope>
109109
</dependency>
110110
<dependency>
111111
<groupId>io.grpc</groupId>
112112
<artifactId>grpc-inprocess</artifactId>
113-
<version>1.59.0</version>
113+
<version>${grpc.version}</version>
114114
<scope>test</scope>
115115
</dependency>
116116
</dependencies>

sdk-actors/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
<properties>
2020
<maven.deploy.skip>false</maven.deploy.skip>
21-
<grpc.version>1.59.0</grpc.version>
2221
</properties>
2322

2423
<dependencies>

sdk-actors/src/test/java/io/dapr/actors/client/DaprGrpcClientTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public void invokeException() {
129129
ExecutionException.class,
130130
"UNKNOWN",
131131
"UNKNOWN: ",
132-
() -> result.block());
132+
result::block);
133133
}
134134

135135
@Test

sdk-actors/src/test/java/io/dapr/actors/runtime/DaprGrpcClientTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public void getActorStateException() {
9696
assertThrowsDaprException(
9797
ExecutionException.class,
9898
"UNKNOWN",
99-
"UNKNOWN: ",
99+
"UNKNOWN: Application error processing RPC",
100100
result::block);
101101
}
102102

@@ -112,7 +112,7 @@ public void saveActorStateTransactionallyException() {
112112
assertThrowsDaprException(
113113
ExecutionException.class,
114114
"UNKNOWN",
115-
"UNKNOWN: ",
115+
"UNKNOWN: Application error processing RPC",
116116
result::block);
117117
}
118118
@Test

sdk-tests/src/test/java/io/dapr/it/spring/messaging/DaprSpringMessagingIT.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,15 @@ public class DaprSpringMessagingIT {
7676
private TestRestController testRestController;
7777

7878
@BeforeAll
79-
public static void setup(){
79+
public static void beforeAll(){
8080
org.testcontainers.Testcontainers.exposeHostPorts(8080);
8181
}
8282

83+
@BeforeEach
84+
public void beforeEach() throws InterruptedException {
85+
Thread.sleep(1000);
86+
}
87+
8388
@Test
8489
public void testDaprMessagingTemplate() throws InterruptedException {
8590
for (int i = 0; i < 10; i++) {
@@ -97,5 +102,4 @@ public void testDaprMessagingTemplate() throws InterruptedException {
97102

98103
assertThat(events.size()).isEqualTo(10);
99104
}
100-
101105
}

sdk/pom.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818

1919
<properties>
2020
<maven.deploy.skip>false</maven.deploy.skip>
21-
<grpc.version>1.59.0</grpc.version>
2221
<argLine>
2322
--add-opens java.base/java.util=ALL-UNNAMED
2423
</argLine>

0 commit comments

Comments
 (0)