Skip to content

Commit bd1667b

Browse files
authored
New overload in invokeBinding + allow null typeref. (#1159)
Signed-off-by: Artur Souza <asouza.pro@gmail.com>
1 parent 83e1753 commit bd1667b

File tree

4 files changed

+64
-8
lines changed

4 files changed

+64
-8
lines changed

sdk/src/main/java/io/dapr/client/AbstractDaprClient.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,14 @@ public <T> Mono<T> invokeBinding(
270270
return this.invokeBinding(bindingName, operation, data, metadata, TypeRef.get(clazz));
271271
}
272272

273+
/**
274+
* {@inheritDoc}
275+
*/
276+
@Override
277+
public Mono<Void> invokeBinding(InvokeBindingRequest request) {
278+
return this.invokeBinding(request, TypeRef.VOID);
279+
}
280+
273281
/**
274282
* {@inheritDoc}
275283
*/

sdk/src/main/java/io/dapr/client/DaprClient.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,14 @@ <T> Mono<T> invokeBinding(String bindingName, String operation, Object data, Map
314314
<T> Mono<T> invokeBinding(String bindingName, String operation, Object data, Map<String, String> metadata,
315315
Class<T> clazz);
316316

317+
/**
318+
* Invokes a Binding operation.
319+
*
320+
* @param request The binding invocation request.
321+
* @return a Mono with void.
322+
*/
323+
Mono<Void> invokeBinding(InvokeBindingRequest request);
324+
317325
/**
318326
* Invokes a Binding operation.
319327
*

sdk/src/main/java/io/dapr/client/DaprClientImpl.java

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -459,8 +459,10 @@ private <T> Subscription<T> buildSubscription(
459459

460460
try {
461461
CloudEvent<T> cloudEvent = new CloudEvent<>();
462-
var object =
463-
DaprClientImpl.this.objectSerializer.deserialize(message.getData().toByteArray(), type);
462+
T object = null;
463+
if (type != null) {
464+
object = DaprClientImpl.this.objectSerializer.deserialize(message.getData().toByteArray(), type);
465+
}
464466
cloudEvent.setData(object);
465467
cloudEvent.setDatacontenttype(message.getDataContentType());
466468
cloudEvent.setId(message.getId());
@@ -528,6 +530,10 @@ public <T> Mono<T> invokeMethod(InvokeMethodRequest invokeMethodRequest, TypeRef
528530

529531
private <T> Mono<T> getMonoForHttpResponse(TypeRef<T> type, DaprHttp.Response r) {
530532
try {
533+
if (type == null) {
534+
return Mono.empty();
535+
}
536+
531537
T object = objectSerializer.deserialize(r.getBody(), type);
532538
if (object == null) {
533539
return Mono.empty();
@@ -585,6 +591,9 @@ public <T> Mono<T> invokeBinding(InvokeBindingRequest request, TypeRef<T> type)
585591
}
586592

587593
try {
594+
if (type == null) {
595+
return Mono.empty();
596+
}
588597
return Mono.justOrEmpty(objectSerializer.deserialize(it.getData().toByteArray(), type));
589598
} catch (IOException e) {
590599
throw DaprException.propagate(e);
@@ -706,13 +715,18 @@ private <T> State<T> buildStateKeyValue(
706715
return new State<>(key, error);
707716
}
708717

709-
ByteString payload = item.getData();
710-
byte[] data = payload == null ? null : payload.toByteArray();
711-
T value = stateSerializer.deserialize(data, type);
712718
String etag = item.getEtag();
713719
if (etag.equals("")) {
714720
etag = null;
715721
}
722+
723+
T value = null;
724+
if (type != null) {
725+
ByteString payload = item.getData();
726+
byte[] data = payload == null ? null : payload.toByteArray();
727+
value = stateSerializer.deserialize(data, type);
728+
}
729+
716730
return new State<>(key, value, etag, item.getMetadataMap(), null);
717731
}
718732

@@ -723,7 +737,11 @@ private <T> State<T> buildStateKeyValue(
723737
TypeRef<T> type) throws IOException {
724738
ByteString payload = response.getData();
725739
byte[] data = payload == null ? null : payload.toByteArray();
726-
T value = stateSerializer.deserialize(data, type);
740+
T value = null;
741+
if (type != null) {
742+
value = stateSerializer.deserialize(data, type);
743+
}
744+
727745
String etag = response.getEtag();
728746
if (etag.equals("")) {
729747
etag = null;
@@ -1108,7 +1126,11 @@ private <T> QueryStateItem<T> buildQueryStateKeyValue(
11081126
}
11091127
ByteString payload = item.getData();
11101128
byte[] data = payload == null ? null : payload.toByteArray();
1111-
T value = stateSerializer.deserialize(data, type);
1129+
T value = null;
1130+
if (type != null) {
1131+
value = stateSerializer.deserialize(data, type);
1132+
}
1133+
11121134
String etag = item.getEtag();
11131135
if (etag.equals("")) {
11141136
etag = null;

sdk/src/test/java/io/dapr/client/DaprClientGrpcTest.java

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
import io.dapr.client.domain.ExecuteStateTransactionRequest;
2626
import io.dapr.client.domain.GetBulkStateRequest;
2727
import io.dapr.client.domain.GetStateRequest;
28+
import io.dapr.client.domain.InvokeBindingRequest;
2829
import io.dapr.client.domain.PublishEventRequest;
2930
import io.dapr.client.domain.RuleMetadata;
3031
import io.dapr.client.domain.State;
@@ -327,7 +328,7 @@ public void invokeBindingCallbackExceptionThrownTest() {
327328
@Test
328329
public void invokeBindingTest() throws IOException {
329330
DaprProtos.InvokeBindingResponse.Builder responseBuilder =
330-
DaprProtos.InvokeBindingResponse.newBuilder().setData(serialize("OK"));
331+
DaprProtos.InvokeBindingResponse.newBuilder().setData(serialize("OK"));
331332
doAnswer((Answer<Void>) invocation -> {
332333
StreamObserver<DaprProtos.InvokeBindingResponse> observer = (StreamObserver<DaprProtos.InvokeBindingResponse>) invocation.getArguments()[1];
333334
observer.onNext(responseBuilder.build());
@@ -339,6 +340,23 @@ public void invokeBindingTest() throws IOException {
339340
result.block();
340341
}
341342

343+
@Test
344+
public void invokeBindingVoidReturnTest() throws IOException {
345+
DaprProtos.InvokeBindingResponse.Builder responseBuilder =
346+
DaprProtos.InvokeBindingResponse.newBuilder().setData(serialize("OK"));
347+
doAnswer((Answer<Void>) invocation -> {
348+
StreamObserver<DaprProtos.InvokeBindingResponse> observer = (StreamObserver<DaprProtos.InvokeBindingResponse>) invocation.getArguments()[1];
349+
observer.onNext(responseBuilder.build());
350+
observer.onCompleted();
351+
return null;
352+
}).when(daprStub).invokeBinding(any(DaprProtos.InvokeBindingRequest.class), any());
353+
354+
var request = new InvokeBindingRequest("BindingName", "MyOperation");
355+
request.setData("request");
356+
Mono<Void> result = client.invokeBinding(request, null);
357+
result.block();
358+
}
359+
342360
@Test
343361
public void invokeBindingByteArrayTest() {
344362
DaprProtos.InvokeBindingResponse.Builder responseBuilder =

0 commit comments

Comments
 (0)