Address comments

Signed-off-by: Artur Souza <asouza.pro@gmail.com>

Author: artursouza

sdk-actors/src/main/java/io/dapr/actors/runtime/ActorStateManager.java

@@ -20,7 +20,6 @@
 import java.time.Duration;
 import java.time.Instant;
 import java.util.ArrayList;
-import java.util.Date;
 import java.util.List;
 import java.util.Map;
 import java.util.NoSuchElementException;
@@ -32,6 +31,9 @@
  */
 public class ActorStateManager {
 
+  private static final StateChangeMetadata REMOVE_STATE_CHANGE_METADATA =
+      new StateChangeMetadata(ActorStateChangeKind.REMOVE, null, null);
+
   /**
    * Provides states using a state store.
    */
@@ -206,9 +208,10 @@ public <T> Mono<Void> set(String stateName, T value, Duration ttl) {
         .switchIfEmpty(this.stateProvider.contains(this.actorTypeName, this.actorId, stateName)
             .map(exists -> {
               var expiration = buildExpiration(ttl);
+              ActorStateChangeKind changeKind = exists ? ActorStateChangeKind.UPDATE : ActorStateChangeKind.ADD;
               this.stateChangeTracker.put(stateName,
                   new StateChangeMetadata(
-                      exists ? ActorStateChangeKind.UPDATE : ActorStateChangeKind.ADD, value, expiration));
+                      changeKind, value, expiration));
               return exists;
             }))
         .then();
@@ -238,7 +241,7 @@ public Mono<Void> remove(String stateName) {
           return true;
         }
 
-        this.stateChangeTracker.put(stateName, new StateChangeMetadata(ActorStateChangeKind.REMOVE, null, null));
+        this.stateChangeTracker.put(stateName, REMOVE_STATE_CHANGE_METADATA);
         return true;
       }
 
@@ -248,7 +251,7 @@ public Mono<Void> remove(String stateName) {
         .switchIfEmpty(this.stateProvider.contains(this.actorTypeName, this.actorId, stateName))
         .filter(exists -> exists)
         .map(exists -> {
-          this.stateChangeTracker.put(stateName, new StateChangeMetadata(ActorStateChangeKind.REMOVE, null, null));
+          this.stateChangeTracker.put(stateName, REMOVE_STATE_CHANGE_METADATA);
           return exists;
         })
         .then();

sdk-tests/components/actorstatestore.yaml

@@ -23,4 +23,4 @@ scopes:
   - actorsdkresiliencytit-demoactorservice
   - actorstateit-statefulactorservice
   - actortimerrecoveryit
-  - actorturnbasedconcurrencyit-myactorservice
+  - actorturnbasedconcurrencyit-myactorservice