Skip to content
This repository was archived by the owner on Dec 6, 2022. It is now read-only.

Conversation

@Pok4
Copy link

@Pok4 Pok4 commented Feb 24, 2022

I update this to make the custom parameters work on php 8.1

Without this modification custom parameters not working on php 8.1, please make the changes :)

PS: As i said, the changes is for 1.2.0 alpha

I update this to make the custom parameters work on php 8.1
@Pok4
Copy link
Author

Pok4 commented Feb 25, 2022

The changes are for 1.2alpha

call_user_func_array(array($instance, $this->action), $this->parameters);

-->

call_user_func_array(array($instance, $this->action), array_values($this->parameters));

@Pok4
Copy link
Author

Pok4 commented Feb 25, 2022

I get a second error: PHP Warning: in file C:/xampp2/htdocs/vendor/dannyvankooten/php-router/src/Router.php on line 124: preg_match_all(): Compilation failed: invalid range in character class at offset 5

They already make a changes - #127

i already edit the files with this changes, i tested everything on php 8.1 and its working...

Please, make the changes to the repo.. I'm completely newbie with github, this is my first pull request...

@Pok4 Pok4 mentioned this pull request Feb 25, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant