refactor: remove code for older zero versions #155
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Gerbuuun
changed the title
Gerbuuun
requested review from
danielroe and
maxstevens-nl
and removed request for
maxstevens-nl
|
I think the concept was that the user wouldn't install an additional zero version, to ensure this lib was compatible. I'm happy to move to peer dep though - was there an issue or reason a user would need to access zero separately from this lib? |
| export { createZeroComposables } from './create-zero-composables' | ||
| export type { QueryResult, UseQueryOptions } from './query' | ||
| export { useQuery, useQueryWithZero } from './query' | ||
| export { useQuery } from './query' |
There was a problem hiding this comment.
Fine to remove useQueryWithZero, but do we still want to export useQuery? Wouldn't it be confusing that the signature of this useQuery is different than the signature of useQuery returned from createZeroComposables?
There was a problem hiding this comment.
Yeah, could be. But if you don't want to use / need createZeroComposables then you want to use that import.
|
See my struggles here: https://discord.com/channels/830183651022471199/1444389536766492843 I do now realise this is only because of how a locally installed package is linked (the whole project and thus it's own installed |
Gerbuuun
changed the title
Zero uses unique symbols for queries on the client and the server.
Running two different versions of
zero(the one included inzero-vueand the one of the project) results in different symbols being used on the client and server thus breaking during SSR.Also removes code to support older zero versions -> min version is
0.24.3...anyways