Fix diskspace command reporting incorrect block size #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove erroneous /8 division when printing BlockSize. The value from the device is already in bytes, not bits. This was causing 4096 byte blocks to be reported as 512 bytes. Fixes #640 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove erroneous
/8division when printing BlockSize in thediskspacecommand.Problem
The
diskspacecommand was reporting 512 bytes as the block size instead of the actual 4096 bytes. This happened because the code incorrectly divided the BlockSize by 8:The value from the device is already in bytes, not bits.
Before
After
References
Fixes #640
🤖 Generated with Claude Code