Skip to content

Removed error log for iOS <17 trying to start tunnel #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Removed error log for iOS <17 trying to start tunnel #526

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1062a11
Removed error log for iOS <17 trying to start tunnel
joao-borges Dec 6, 2024
2fb1267
Merge branch 'danielpaulus:main' into remove_ios16_log_tunnel
joao-borges Dec 18, 2024
f8d1d03
Merge branch 'main' into remove_ios16_log_tunnel
danielpaulus Jan 24, 2025
2a6eb33
Merge branch 'main' into remove_ios16_log_tunnel
joao-borges Feb 18, 2025
b5257c5
Merge branch 'main' into remove_ios16_log_tunnel
joao-borges Feb 19, 2025
44baa9b
Merge branch 'main' into remove_ios16_log_tunnel
gmegidish Nov 21, 2025
e007707
Merge branch 'main' into remove_ios16_log_tunnel
aluedeke Dec 1, 2025
dae1b49
Merge branch 'main' into remove_ios16_log_tunnel
joao-borges Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions ios/tunnel/tunnel_api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,14 @@ func (m *TunnelManager) UpdateTunnels(ctx context.Context) error {
Warn("failed to start tunnel")
continue
}
m.mux.Lock()
localTunnels[udid] = t
m.tunnels[udid] = t
m.mux.Unlock()
if t.Address != "" {
log.WithField("udid", udid).Info("Tunnel started successfully")

m.mux.Lock()
localTunnels[udid] = t
m.tunnels[udid] = t
m.mux.Unlock()
}
}
for udid, tun := range localTunnels {
idx := slices.ContainsFunc(devices.DeviceList, func(entry ios.DeviceEntry) bool {
Expand Down Expand Up @@ -336,7 +340,6 @@ func (m *TunnelManager) stopTunnel(t Tunnel) error {
}

func (m *TunnelManager) startTunnel(ctx context.Context, device ios.DeviceEntry) (Tunnel, error) {
log.WithField("udid", device.Properties.SerialNumber).Info("start tunnel")
startTunnelCtx, cancel := context.WithTimeout(ctx, m.startTunnelTimeout)
defer cancel()
version, err := ios.GetProductVersion(device)
Expand Down Expand Up @@ -400,7 +403,9 @@ func (m manualPairingTunnelStart) StartTunnel(ctx context.Context, device ios.De
}
return ManualPairAndConnectToTunnel(ctx, device, p)
}
return Tunnel{}, fmt.Errorf("manualPairingTunnelStart: unsupported iOS version %s", version.String())

log.WithField("udid", device.Properties.SerialNumber).Tracef("manualPairingTunnelStart: unsupported iOS version %s", version.String())
return Tunnel{}, nil
}

type deviceList struct {
Expand Down
Loading