Overlay.qll: remove overlay[local?] module; in favour of explicit annotations

d10c · d10c · commit f46540201119 · 2025-09-05T18:02:01.000+02:00
diff --git a/python/ql/lib/semmle/python/Overlay.qll b/python/ql/lib/semmle/python/Overlay.qll
@@ -1,8 +1,6 @@
 /**
  * Defines entity discard predicates for Python overlay analysis.
  */
-overlay[local?]
-module;
 
 import python
 
@@ -143,6 +141,7 @@ private predicate discardVar(@py_base_var n) {
   )
 }
 
+overlay[local]
 final private class DiscardableVar extends DiscardableBaseVar instanceof @py_variable {
   override string getPath() {
     exists(Discardable parent | result = parent.getPath() |
@@ -153,6 +152,7 @@ final private class DiscardableVar extends DiscardableBaseVar instanceof @py_var
   }
 }
 
+overlay[local]
 final private class DiscardableSsaVar extends DiscardableBaseVar instanceof @py_ssa_var {
   override string getPath() {
     exists(DiscardableSsaVar other | result = other.getPath() |

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,6 @@`
`1`	`1`	`/**`
`2`	`2`	`* Defines entity discard predicates for Python overlay analysis.`
`3`	`3`	`*/`
`4`		`-overlay[local?]`
`5`		`-module;`
`6`	`4`
`7`	`5`	`import python`
`8`	`6`
`@@ -143,6 +141,7 @@ private predicate discardVar(@py_base_var n) {`
`143`	`141`	`)`
`144`	`142`	`}`
`145`	`143`
	`144`	`+overlay[local]`
`146`	`145`	`final private class DiscardableVar extends DiscardableBaseVar instanceof @py_variable {`
`147`	`146`	`override string getPath() {`
`148`	`147`	`exists(Discardable parent \| result = parent.getPath() \|`
`@@ -153,6 +152,7 @@ final private class DiscardableVar extends DiscardableBaseVar instanceof @py_var`
`153`	`152`	`}`
`154`	`153`	`}`
`155`	`154`
	`155`	`+overlay[local]`
`156`	`156`	`final private class DiscardableSsaVar extends DiscardableBaseVar instanceof @py_ssa_var {`
`157`	`157`	`override string getPath() {`
`158`	`158`	`exists(DiscardableSsaVar other \| result = other.getPath() \|`