#20 adding correct bool insertion via the line protocol

Author: d-led

README.md

@@ -13,9 +13,9 @@ A batching api leans towards thousands inserts per second. Behind the scenes, th
 
 ## Status
 
-Build and test ok on Win10/Ubuntu64/OSX.
-
-Feel free to contribute, as the progress is rather sporadic due to lack of spare time.
+- Build and test ok on Win10/Ubuntu64/OSX.
+- Feel free to contribute, as the progress is rather sporadic due to lack of spare time.
+- tested with InfluxDB v1.2.4, v1.7.5, v1.7.6
 
 ## Synchronous insertion
 

src/influxdb-cpp-rest/influxdb_line.h

@@ -48,7 +48,8 @@ namespace influxdb {
             template<
                 class V,
                 typename std::enable_if<
-                    std::is_integral<V>::value
+                    std::is_integral<V>::value &&
+                    (! std::is_same<bool, V>::value)
                 >::type* = nullptr
             >
                 key_value_pairs& add(std::string const& key, V const& value) {
@@ -61,6 +62,23 @@ namespace influxdb {
                 return *this;
             }
 
+            template<
+                class V,
+                typename std::enable_if<
+                    std::is_integral<V>::value &&
+                    ( std::is_same<bool, V>::value)
+                >::type* = nullptr
+            >
+                key_value_pairs& add(std::string const& key, V const& value) {
+                ::influxdb::utility::throw_on_invalid_identifier(key);
+
+                add_comma_if_necessary();
+
+                format_to(res, "{}={}", key, value);
+
+                return *this;
+            }
+
             template<
                 class V,
                 typename std::enable_if<

src/test/simple_api_test.cpp

@@ -109,6 +109,19 @@ TEST_CASE_METHOD(simple_connected_test, "inserting values using the simple api",
     CHECK(res.contains("hello world!"));
 }
 
+TEST_CASE_METHOD(simple_connected_test, "inserting boolean values", "[connected]") {
+    db.insert(line("boolean_test", key_value_pairs("mytag", true), key_value_pairs("value", false)));
+    db.insert(line("boolean_test", key_value_pairs("mytag", false), key_value_pairs("value", true)));
+
+    wait_for([] {return false; },3);
+
+    auto res = result("boolean_test");
+    CHECK(res.contains("true"));
+    CHECK(res.contains("false"));
+    // tags are not booleans, thus quoted
+    CHECK(res.contains("\"true\""));
+    CHECK(res.contains("\"false\""));
+}
 
 TEST_CASE_METHOD(simple_connected_test, "inserting multiple lines in one call") {
     auto l = line