Skip to content

fix: clear cache and retry on cvmfs installation failure #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: clear cache and retry on cvmfs installation failure #48

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604d535
fix: clear cache and retry on cvmfs installation failure
wdconinc Aug 25, 2025
4d04595
Remove `set -e` again
wdconinc Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions setup-cvmfs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#!/usr/bin/env bash

# Fail on errors
set -e

# Platform specific install
if [ "$(uname)" == "Linux" ]; then
# download from cache
Expand All @@ -23,7 +26,16 @@ if [ "$(uname)" == "Linux" ]; then
echo "::group::Installing cvmfs"
sudo rm -f /var/lib/man-db/auto-update
sudo apt-get -q update
# Attempt install
sudo apt-get -q -y install cvmfs
if [ $? -ne 0 ]; then
# If it fails, try to clear cache and try again
echo "First attempt to install cvmfs failed, trying to clear cache and retrying"
sudo rm -rf /var/cache/apt/archives
sudo rm -rf /var/cache/apt/lists
sudo apt-get -q update
sudo apt-get -q -y install cvmfs
Copy link
Contributor

@ocaisa ocaisa Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is unlikely to fail again, but you should probably check anyway given why you are introducing this change

Copy link
Collaborator Author

@wdconinc wdconinc Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just don't think this PR is the right solution. If you look at your original failing pipeline: https://github.com/DUNE-DAQ/daq-release/actions/runs/16244930712/job/45866367226#step:3:58, you'll see that it is already running in bash -e, so doing something like if [ $? -ne 0 ] is not going to catch this since we probably don't even return a failing exit code from apt-get install (or we would have bailed out earlier).

I have been trying to find some way to trigger this issue (GHA or locally), but no luck so far.

fi
# install cvmfs config package
if [ "${CVMFS_CONFIG_PACKAGE}" == "cvmfs-config-default" ]; then
sudo apt-get -q -y install cvmfs-config-default
Expand Down
Loading