Merge pull request #61 from DrDaveD/fix-ok

Fix /ok, update to 1.29

Author: DrDaveD

rpm/cvmfs-servermon.spec

@@ -1,6 +1,6 @@
 Summary: CernVM File System Server Monitoring
 Name: cvmfs-servermon
-Version: 1.28
+Version: 1.29
 # The release_prefix macro is used in the OBS prjconf, don't change its name
 %define release_prefix 1
 Release: %{release_prefix}%{?dist}
@@ -68,6 +68,9 @@ setsebool -P httpd_can_network_connect 1 2>/dev/null || true
 /usr/share/cvmfs-servermon
 
 %changelog
+* Mon Feb 10 2025 Dave Dykstra <dwd@fnal.gov> - 1.29-1
+- Fix the /ok api, which was showing nothing.
+
 * Mon Sep  2 2024 Dave Dykstra <dwd@fnal.gov> - 1.28-1
 - Prevent json pretty printer from breaking up long strings, the way
   pyhon2 did it.

webapi/cvmfsmon_api.py

@@ -203,9 +203,8 @@ def dispatch(version, montests, parameters, start_response, environ):
     for repo in replicas_and_repos:
         if repo in excludes:
             continue
-        results = []
         if montests == 'ok':
-            results.append([ 'ok', repo, 'OK', '' ])
+            allresults.append([ 'ok', repo, 'OK', '' ])
             continue
         errormsg = ""
         doupdated = False
@@ -245,6 +244,7 @@ def dispatch(version, montests, parameters, start_response, environ):
         except:
             errormsg =  str(sys.exc_info()[1])
 
+        results = []
         if domontest('check', montests):
             results.append(cvmfsmon_check.runtest(repo, repo_status, errormsg))