Use import/no-duplicates lint rule (#3059)

Author: AndreasArvidsson

eslint.config.mts

@@ -53,6 +53,8 @@ const rootConfig: ConfigWithExtends = {
 
   rules: {
     "import/no-relative-packages": "error",
+    "import/no-duplicates": "error",
+    "unused-imports/no-unused-imports": "error",
     "@typescript-eslint/consistent-type-imports": "error",
     "@typescript-eslint/consistent-type-assertions": [
       "error",
@@ -75,7 +77,6 @@ const rootConfig: ConfigWithExtends = {
     "@typescript-eslint/no-explicit-any": "off",
     "@typescript-eslint/no-inferrable-types": "off",
     "@typescript-eslint/no-non-null-assertion": "off",
-    "unused-imports/no-unused-imports": "error",
     "@typescript-eslint/no-unused-vars": [
       "error",
       {

package.json

@@ -32,11 +32,11 @@
   },
   "devDependencies": {
     "@eslint/eslintrc": "^3.3.1",
-    "@eslint/js": "^9.31.0",
+    "@eslint/js": "^9.32.0",
     "@pnpm/meta-updater": "^2.0.6",
     "@types/node": "^24.1.0",
     "esbuild": "^0.25.8",
-    "eslint": "^9.31.0",
+    "eslint": "^9.32.0",
     "eslint-config-prettier": "^10.1.8",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-import": "^2.32.0",

packages/common/src/scopeSupportFacets/scopeSupportFacets.types.ts

@@ -1,5 +1,7 @@
-import type { SimpleScopeTypeType } from "../types/command/PartialTargetDescriptor.types";
-import { type ScopeType } from "../types/command/PartialTargetDescriptor.types";
+import type {
+  ScopeType,
+  SimpleScopeTypeType,
+} from "../types/command/PartialTargetDescriptor.types";
 
 export const scopeSupportFacets = [
   "command",

packages/cursorless-engine/src/CommandHistory.ts

@@ -2,11 +2,11 @@ import type {
   ActionDescriptor,
   CommandComplete,
   CommandHistoryEntry,
+  CommandHistoryStorage,
   CommandServerApi,
   IDE,
   ReadOnlyHatMap,
 } from "@cursorless/common";
-import { type CommandHistoryStorage } from "@cursorless/common";
 import { produce } from "immer";
 import { v4 as uuid } from "uuid";
 import type { CommandRunner } from "./CommandRunner";

packages/cursorless-engine/src/CommandHistoryAnalyzer.ts

@@ -1,10 +1,11 @@
 import type {
   CommandHistoryEntry,
+  CommandHistoryStorage,
   Modifier,
   PartialPrimitiveTargetDescriptor,
   ScopeType,
 } from "@cursorless/common";
-import { showWarning, type CommandHistoryStorage } from "@cursorless/common";
+import { showWarning } from "@cursorless/common";
 import { groupBy, map, sum } from "lodash-es";
 import { canonicalizeAndValidateCommand } from "./core/commandVersionUpgrades/canonicalizeAndValidateCommand";
 import { ide } from "./singletons/ide.singleton";

packages/cursorless-engine/src/core/StoredTargets.ts

@@ -1,7 +1,6 @@
-import { DefaultMap, Notifier } from "@cursorless/common";
-import type { Target } from "../typings/target.types";
 import type { StoredTargetKey } from "@cursorless/common";
-import { storedTargetKeys } from "@cursorless/common";
+import { DefaultMap, Notifier, storedTargetKeys } from "@cursorless/common";
+import type { Target } from "../typings/target.types";
 import { UndoStack } from "./UndoStack";
 
 const MAX_HISTORY_LENGTH = 25;

packages/cursorless-engine/src/core/commandVersionUpgrades/upgradeV1ToV2/upgradeV1ToV2.ts

@@ -1,17 +1,16 @@
-import type { ActionType, ActionTypeV2 } from "@cursorless/common";
-import type { CommandV2 } from "@cursorless/common";
 import type {
+  ActionType,
+  ActionTypeV2,
+  CommandV1,
+  CommandV2,
+  ModifierV0V1,
   ModifierV2,
   PartialPrimitiveTargetDescriptorV2,
+  PartialPrimitiveTargetV0V1,
   PartialRangeTargetDescriptorV2,
   PartialTargetDescriptorV2,
-  SimpleScopeTypeTypeV2,
-} from "@cursorless/common";
-import type {
-  CommandV1,
-  ModifierV0V1,
-  PartialPrimitiveTargetV0V1,
   PartialTargetV0V1,
+  SimpleScopeTypeTypeV2,
 } from "@cursorless/common";
 import { upgradeStrictHere } from "./upgradeStrictHere";
 

packages/cursorless-engine/src/core/commandVersionUpgrades/upgradeV5ToV6/upgradeV5ToV6.ts

@@ -5,6 +5,8 @@ import type {
   CommandV6,
   DestinationDescriptor,
   EnforceUndefined,
+  ExecuteCommandOptions,
+  GetTextActionOptions,
   HighlightActionDescriptor,
   HighlightId,
   ImplicitDestinationDescriptor,
@@ -27,10 +29,6 @@ import type {
   ReplaceWith,
   WrapWithSnippetArg,
 } from "@cursorless/common";
-import {
-  type ExecuteCommandOptions,
-  type GetTextActionOptions,
-} from "@cursorless/common";
 import canonicalizeActionName from "./canonicalizeActionName";
 
 export function upgradeV5ToV6(command: CommandV5): EnforceUndefined<CommandV6> {

packages/cursorless-engine/src/cursorlessEngine.ts

@@ -3,14 +3,12 @@ import type {
   CommandServerApi,
   Hats,
   IDE,
+  RawTreeSitterQueryProvider,
   ScopeProvider,
+  TalonSpokenForms,
+  TreeSitter,
 } from "@cursorless/common";
-import {
-  ensureCommandShape,
-  type RawTreeSitterQueryProvider,
-  type TalonSpokenForms,
-  type TreeSitter,
-} from "@cursorless/common";
+import { ensureCommandShape } from "@cursorless/common";
 import { KeyboardTargetUpdater } from "./KeyboardTargetUpdater";
 import type {
   CommandRunnerDecorator,

packages/cursorless-engine/src/customCommandGrammar/grammarUtil.ts

@@ -1,28 +1,26 @@
 import type {
   BringMoveActionDescriptor,
+  ContainingScopeModifier,
   DestinationDescriptor,
   Direction,
   InsertionMode,
+  Modifier,
   PartialListTargetDescriptor,
+  PartialMark,
+  PartialPrimitiveTargetDescriptor,
   PartialRangeTargetDescriptor,
+  PartialTargetDescriptor,
   PartialTargetMark,
   PrimitiveDestinationDescriptor,
   RelativeScopeModifier,
-} from "@cursorless/common";
-import {
-  type ContainingScopeModifier,
-  type Modifier,
-  type PartialMark,
-  type PartialPrimitiveTargetDescriptor,
-  type PartialTargetDescriptor,
-  type ScopeType,
-  type SimpleActionDescriptor,
-  type SimpleActionName,
-  type SimplePartialMark,
-  type SimpleScopeType,
-  type SimpleScopeTypeType,
-  type SurroundingPairName,
-  type SurroundingPairScopeType,
+  ScopeType,
+  SimpleActionDescriptor,
+  SimpleActionName,
+  SimplePartialMark,
+  SimpleScopeType,
+  SimpleScopeTypeType,
+  SurroundingPairName,
+  SurroundingPairScopeType,
 } from "@cursorless/common";
 import type { WithPlaceholders } from "./WithPlaceholders";