keyboard: Support slice ranges (#2430)

- Depends on #2429

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

Author: pokey

packages/cursorless-vscode-e2e/src/suite/keyboard/basic.vscode.test.ts

@@ -83,6 +83,14 @@ const testCases: TestCase[] = [
     keySequence: ["da", "aw", "wp", "aw", "wp"],
     finalContent: "((a))\n",
   },
+  {
+    name: "slice range",
+    initialContent: "aaa bbb\nccc ddd",
+    // keyboard air
+    // keyboard slice past cap
+    keySequence: ["da", "fs", "dc", "st", "c"],
+    finalContent: " bbb\n ddd",
+  },
   {
     name: "simple mark",
     initialContent: "aaa bbb",
@@ -94,15 +102,15 @@ const testCases: TestCase[] = [
   {
     name: "simple mark range",
     initialContent: "aaa bbb ccc",
-    // keyboard air
+    // keyboard bat
     // keyboard past this
     keySequence: ["db", "fk", "mc", "c"],
     finalContent: "aaa ",
   },
   {
     name: "simple mark list",
     initialContent: "aaa bbb ccc",
-    // keyboard air
+    // keyboard bat
     // keyboard and this
     keySequence: ["db", "fa", "mc", "c"],
     finalContent: "aaa  ",

packages/cursorless-vscode/src/keyboard/KeyboardCommandsTargeted.ts

@@ -15,7 +15,11 @@ import KeyboardCommandsModal from "./KeyboardCommandsModal";
 import KeyboardHandler from "./KeyboardHandler";
 import { SimpleKeyboardActionDescriptor } from "./KeyboardActionType";
 
-export type TargetingMode = "replace" | "makeRange" | "makeList";
+export type TargetingMode =
+  | "replace"
+  | "makeRange"
+  | "makeVerticalRange"
+  | "makeList";
 
 interface TargetDecoratedMarkArgument {
   color?: HatColor;
@@ -113,6 +117,15 @@ export default class KeyboardCommandsTargeted {
           excludeActive: false,
           excludeAnchor: false,
         };
+      case "makeVerticalRange":
+        return {
+          type: "range",
+          anchor: getKeyboardTarget(),
+          active: target,
+          excludeActive: false,
+          excludeAnchor: false,
+          rangeType: "vertical",
+        };
       case "makeList":
         return {
           type: "list",

packages/cursorless-vscode/src/keyboard/TokenTypes.ts

@@ -31,6 +31,7 @@ type ModifierType =
 export type MiscValue =
   | "combineColorAndShape"
   | "makeRange"
+  | "makeVerticalRange"
   | "makeList"
   | "forward"
   | "backward";
@@ -65,7 +66,7 @@ export interface TokenTypeValueMap {
   wrap: SpecificKeyboardActionDescriptor<"wrap">;
 
   // misc config section
-  targetingMode: "makeRange" | "makeList";
+  targetingMode: "makeRange" | "makeVerticalRange" | "makeList";
   combineColorAndShape: "combineColorAndShape";
   direction: "forward" | "backward";
 

packages/cursorless-vscode/src/keyboard/getTokenTypeKeyMaps.ts

@@ -55,7 +55,7 @@ export function getTokenTypeKeyMaps(
     targetingMode: config.getTokenKeyMap(
       "targetingMode",
       "misc",
-      only("makeRange", "makeList"),
+      only("makeRange", "makeVerticalRange", "makeList"),
     ),
     combineColorAndShape: config.getTokenKeyMap(
       "combineColorAndShape",

packages/cursorless-vscode/src/keyboard/keyboard-config.fixture.json

@@ -62,6 +62,7 @@
   "cursorless.experimental.keyboard.modal.keybindings.misc": {
     "fx": "combineColorAndShape",
     "fk": "makeRange",
+    "fs": "makeVerticalRange",
     "fa": "makeList",
     "-": "backward"
   },