Disallow type import exceptions in .eslintrc (#1280)

This PR cleans up our cross-package dependency graph even more by
removing our exceptiosn for type imports, as well as restricting which
packages can import each other via `@cursorless/foo` imports

## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: pokey

packages/common/.eslintrc.json

@@ -5,7 +5,7 @@
       {
         "patterns": [
           {
-            "group": ["../*"],
+            "group": ["@cursorless/*", "../*"],
             "message": "Common shouldn't have any dependencies"
           }
         ],

packages/common/getFakeCommandServerApi.ts

@@ -0,0 +1,11 @@
+import { CommandServerApi } from "./types/CommandServerApi";
+
+export function getFakeCommandServerApi(): CommandServerApi {
+  return {
+    signals: {
+      prePhrase: {
+        getVersion: async () => null,
+      },
+    },
+  };
+}

packages/common/ide/.eslintrc.json

@@ -5,7 +5,7 @@
       {
         "patterns": [
           {
-            "group": ["../../*"],
+            "group": ["@cursorless/*", "../../*"],
             "message": "Common shouldn't have any dependencies"
           }
         ],

packages/common/ide/fake/.eslintrc.json

@@ -5,7 +5,7 @@
       {
         "patterns": [
           {
-            "group": ["../../../*"],
+            "group": ["@cursorless/*", "../../../*"],
             "message": "Common shouldn't depend on Cursorless extension"
           }
         ],

packages/common/ide/normalized/.eslintrc.json

@@ -5,7 +5,7 @@
       {
         "patterns": [
           {
-            "group": ["../../../*"],
+            "group": ["@cursorless/*", "../../../*"],
             "message": "Common shouldn't depend on Cursorless extension"
           }
         ],

packages/common/ide/spy/.eslintrc.json

@@ -5,7 +5,7 @@
       {
         "patterns": [
           {
-            "group": ["../../../*"],
+            "group": ["@cursorless/*", "../../../*"],
             "message": "Common shouldn't depend on Cursorless extension"
           }
         ],

packages/common/ide/types/.eslintrc.json

@@ -5,7 +5,7 @@
       {
         "patterns": [
           {
-            "group": ["../../../*"],
+            "group": ["@cursorless/*", "../../../*"],
             "message": "Common shouldn't have any dependencies"
           }
         ],

packages/common/index.ts

@@ -1,8 +1,5 @@
 export * from "./commandIds";
-export {
-  extractTargetedMarks,
-  extractTargetKeys,
-} from "./testUtil/extractTargetedMarks";
+export * from "./testUtil/extractTargetedMarks";
 export { default as FakeIDE } from "./ide/fake/FakeIDE";
 export {
   runTestSubset,
@@ -45,15 +42,21 @@ export * from "./types/TextEditorDecorationType";
 export * from "./types/TextEditorEdit";
 export * from "./types/TextEditorOptions";
 export * from "./types/TextLine";
+export * from "./types/Token";
+export * from "./types/HatTokenMap";
+export * from "./util/textFormatters";
+export * from "./types/snippet.types";
 export * from "./testUtil/fromPlainObject";
 export * from "./testUtil/toPlainObject";
 export { default as DefaultMap } from "./util/DefaultMap";
 export * from "./types/GeneralizedRange";
+export * from "./types/RangeOffsets";
 export * from "./util/omitByDeep";
 export * from "./testUtil/isTesting";
 export * from "./testUtil/testConstants";
 export * from "./testUtil/getFixturePaths";
 export * from "./testUtil/serialize";
+export * from "./testUtil/TestCaseSnapshot";
 export * from "./util/typeUtils";
 export * from "./ide/types/hatStyles.types";
 export * from "./errors";
@@ -71,3 +74,5 @@ export * from "./types/command/legacy/PartialTargetDescriptorV3.types";
 export * from "./types/CommandServerApi";
 export * from "./util/itertools";
 export * from "./extensionDependencies";
+export * from "./getFakeCommandServerApi";
+export * from "./types/TestCaseFixture";

packages/common/testUtil/.eslintrc.json

@@ -5,9 +5,8 @@
       {
         "patterns": [
           {
-            "group": ["../../*"],
-            "message": "Common shouldn't have any dependencies",
-            "allowTypeImports": true
+            "group": ["@cursorless/*", "../../*"],
+            "message": "Common shouldn't have any dependencies"
           }
         ],
         "paths": [

packages/common/testUtil/TestCaseSnapshot.ts

@@ -0,0 +1,31 @@
+import {
+  RangePlainObject,
+  SelectionPlainObject,
+  SerializedMarks,
+  TargetPlainObject,
+} from "./toPlainObject";
+
+export type TestCaseSnapshot = {
+  documentContents: string;
+  selections: SelectionPlainObject[];
+  clipboard?: string;
+  // TODO Visible ranges are not asserted during testing, see:
+  // https://github.com/cursorless-dev/cursorless/issues/160
+  visibleRanges?: RangePlainObject[];
+  marks?: SerializedMarks;
+  thatMark?: TargetPlainObject[];
+  sourceMark?: TargetPlainObject[];
+  timeOffsetSeconds?: number;
+
+  /**
+   * Extra information about the snapshot. Must be json serializable
+   */
+  metadata?: unknown;
+};
+
+export type ExtraSnapshotField = keyof TestCaseSnapshot;
+export type ExcludableSnapshotField = keyof TestCaseSnapshot;
+
+export interface ExtraContext {
+  startTimestamp?: bigint;
+}