Remove jsx attribute from item scope (#2039)

Fixes #2034

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [-] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [-] I have not broken the cheatsheet

Author: AndreasArvidsson

packages/cursorless-engine/src/languages/getNodeMatcher.ts

@@ -13,7 +13,6 @@ import { LegacyLanguageId } from "./LegacyLanguageId";
 import cpp from "./cpp";
 import csharp from "./csharp";
 import go from "./go";
-import { patternMatchers as html } from "./html";
 import java from "./java";
 import latex from "./latex";
 import markdown from "./markdown";
@@ -59,7 +58,6 @@ export const languageMatchers: Record<
   csharp,
   clojure,
   go,
-  html,
   java,
   javascript: typescript,
   javascriptreact: typescript,
@@ -73,7 +71,6 @@ export const languageMatchers: Record<
   rust,
   typescript,
   typescriptreact: typescript,
-  xml: html,
 };
 
 function matcherIncludeSiblings(matcher: NodeMatcher): NodeMatcher {

packages/cursorless-engine/src/languages/html.ts

@@ -5,7 +5,6 @@ import { argumentMatcher, createPatternMatchers } from "../util/nodeMatchers";
 const nodeMatchers: Partial<
   Record<SimpleScopeTypeType, NodeMatcherAlternative>
 > = {
-  collectionItem: "jsx_attribute",
   argumentOrParameter: argumentMatcher("formal_parameters", "arguments"),
 };
 

packages/cursorless-engine/src/languages/typescript.ts

@@ -0,0 +1,25 @@
+languageId: typescriptreact
+command:
+  version: 6
+  spokenForm: change every item
+  action:
+    name: clearAndSetSelection
+    target:
+      type: primitive
+      modifiers:
+        - type: everyScope
+          scopeType: {type: collectionItem}
+  usePrePhraseSnapshot: true
+initialState:
+  documentContents: <div value={[1, 2]}>
+  selections:
+    - anchor: {line: 0, character: 13}
+      active: {line: 0, character: 13}
+  marks: {}
+finalState:
+  documentContents: <div value={[, ]}>
+  selections:
+    - anchor: {line: 0, character: 13}
+      active: {line: 0, character: 13}
+    - anchor: {line: 0, character: 15}
+      active: {line: 0, character: 15}

packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/html/clearEveryItem.yml

@@ -0,0 +1,23 @@
+languageId: typescriptreact
+command:
+  version: 6
+  spokenForm: change item
+  action:
+    name: clearAndSetSelection
+    target:
+      type: primitive
+      modifiers:
+        - type: containingScope
+          scopeType: {type: collectionItem}
+  usePrePhraseSnapshot: true
+initialState:
+  documentContents: <div value={[1, 2]}>
+  selections:
+    - anchor: {line: 0, character: 13}
+      active: {line: 0, character: 13}
+  marks: {}
+finalState:
+  documentContents: <div value={[, 2]}>
+  selections:
+    - anchor: {line: 0, character: 13}
+      active: {line: 0, character: 13}