Include @ in name for scm language (#1927)

pokey · web-flow · commit 4ec5b952666a · 2023-10-05T05:39:31.000Z
Fixes #1923 ## Checklist - [ ] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [ ] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [ ] I have not broken the cheatsheet
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/changeEveryName.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/changeEveryName.yml
@@ -17,11 +17,11 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: (aaa) @ @ @
+  documentContents: "(aaa)   "
   selections:
+    - anchor: {line: 0, character: 6}
+      active: {line: 0, character: 6}
     - anchor: {line: 0, character: 7}
       active: {line: 0, character: 7}
-    - anchor: {line: 0, character: 9}
-      active: {line: 0, character: 9}
-    - anchor: {line: 0, character: 11}
-      active: {line: 0, character: 11}
+    - anchor: {line: 0, character: 8}
+      active: {line: 0, character: 8}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/changeName.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/changeName.yml
@@ -17,7 +17,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: (aaa) @
+  documentContents: "(aaa) "
   selections:
-    - anchor: {line: 0, character: 7}
-      active: {line: 0, character: 7}
+    - anchor: {line: 0, character: 6}
+      active: {line: 0, character: 6}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/changeName2.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/changeName2.yml
@@ -17,7 +17,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: "eee: (aaa) @"
+  documentContents: "eee: (aaa) "
   selections:
-    - anchor: {line: 0, character: 12}
-      active: {line: 0, character: 12}
+    - anchor: {line: 0, character: 11}
+      active: {line: 0, character: 11}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/changeName3.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/changeName3.yml
@@ -17,7 +17,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: "eee: _ @"
+  documentContents: "eee: _ "
   selections:
-    - anchor: {line: 0, character: 8}
-      active: {line: 0, character: 8}
+    - anchor: {line: 0, character: 7}
+      active: {line: 0, character: 7}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/chuckName.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/chuckName.yml
@@ -17,7 +17,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: "(aaa) "
+  documentContents: (aaa)
   selections:
     - anchor: {line: 0, character: 0}
       active: {line: 0, character: 0}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/chuckName2.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/chuckName2.yml
@@ -17,7 +17,7 @@ initialState:
       active: {line: 0, character: 20}
   marks: {}
 finalState:
-  documentContents: "(aaa) @bbb @ccc "
+  documentContents: (aaa) @bbb @ccc
   selections:
-    - anchor: {line: 0, character: 16}
-      active: {line: 0, character: 16}
+    - anchor: {line: 0, character: 15}
+      active: {line: 0, character: 15}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearEveryName.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearEveryName.yml
@@ -16,9 +16,9 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: (aaa) @ @
+  documentContents: "(aaa)  "
   selections:
+    - anchor: {line: 0, character: 6}
+      active: {line: 0, character: 6}
     - anchor: {line: 0, character: 7}
       active: {line: 0, character: 7}
-    - anchor: {line: 0, character: 9}
-      active: {line: 0, character: 9}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearEveryName2.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearEveryName2.yml
@@ -16,9 +16,9 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: "[(aaa) (bbb)] @ @"
+  documentContents: "[(aaa) (bbb)]  "
   selections:
+    - anchor: {line: 0, character: 14}
+      active: {line: 0, character: 14}
     - anchor: {line: 0, character: 15}
       active: {line: 0, character: 15}
-    - anchor: {line: 0, character: 17}
-      active: {line: 0, character: 17}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearEveryName3.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearEveryName3.yml
@@ -21,10 +21,10 @@ initialState:
 finalState:
   documentContents: |-
     (anonymous_node
-      name: (_) @ @
+      name: (_)  
     )
   selections:
+    - anchor: {line: 1, character: 12}
+      active: {line: 1, character: 12}
     - anchor: {line: 1, character: 13}
       active: {line: 1, character: 13}
-    - anchor: {line: 1, character: 15}
-      active: {line: 1, character: 15}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName.yml
@@ -16,7 +16,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: (aaa) @
+  documentContents: "(aaa) "
   selections:
-    - anchor: {line: 0, character: 7}
-      active: {line: 0, character: 7}
+    - anchor: {line: 0, character: 6}
+      active: {line: 0, character: 6}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName2.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName2.yml
@@ -16,7 +16,7 @@ initialState:
       active: {line: 0, character: 11}
   marks: {}
 finalState:
-  documentContents: (aaa) @bbb @
+  documentContents: "(aaa) @bbb "
   selections:
-    - anchor: {line: 0, character: 12}
-      active: {line: 0, character: 12}
+    - anchor: {line: 0, character: 11}
+      active: {line: 0, character: 11}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName3.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName3.yml
@@ -16,7 +16,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: (aaa) @
+  documentContents: "(aaa) "
   selections:
-    - anchor: {line: 0, character: 7}
-      active: {line: 0, character: 7}
+    - anchor: {line: 0, character: 6}
+      active: {line: 0, character: 6}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName4.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName4.yml
@@ -16,7 +16,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: "\"aaa\" @"
+  documentContents: "\"aaa\" "
   selections:
-    - anchor: {line: 0, character: 7}
-      active: {line: 0, character: 7}
+    - anchor: {line: 0, character: 6}
+      active: {line: 0, character: 6}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName5.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName5.yml
@@ -16,7 +16,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: "[(aaa) (bbb)] @"
+  documentContents: "[(aaa) (bbb)] "
   selections:
-    - anchor: {line: 0, character: 15}
-      active: {line: 0, character: 15}
+    - anchor: {line: 0, character: 14}
+      active: {line: 0, character: 14}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName6.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName6.yml
@@ -23,8 +23,8 @@ finalState:
   documentContents: |-
 
     (anonymous_node
-      name: (_) @
+      name: (_) 
     )
   selections:
-    - anchor: {line: 2, character: 13}
-      active: {line: 2, character: 13}
+    - anchor: {line: 2, character: 12}
+      active: {line: 2, character: 12}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName7.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/clearName7.yml
@@ -21,8 +21,8 @@ initialState:
 finalState:
   documentContents: |-
     (anonymous_node
-      name: (_) @
+      name: (_) 
     )
   selections:
-    - anchor: {line: 1, character: 13}
-      active: {line: 1, character: 13}
+    - anchor: {line: 1, character: 12}
+      active: {line: 1, character: 12}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/drinkName.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/drinkName.yml
@@ -17,7 +17,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: "eee: _ @ @bbb @ccc"
+  documentContents: "eee: _  @bbb @ccc"
   selections:
-    - anchor: {line: 0, character: 8}
-      active: {line: 0, character: 8}
+    - anchor: {line: 0, character: 7}
+      active: {line: 0, character: 7}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/pourName.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/pourName.yml
@@ -17,7 +17,7 @@ initialState:
       active: {line: 0, character: 0}
   marks: {}
 finalState:
-  documentContents: "eee: _ @bbb @ccc @"
+  documentContents: "eee: _ @bbb @ccc "
   selections:
-    - anchor: {line: 0, character: 18}
-      active: {line: 0, character: 18}
+    - anchor: {line: 0, character: 17}
+      active: {line: 0, character: 17}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/pourName2.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/pourName2.yml
@@ -17,7 +17,7 @@ initialState:
       active: {line: 0, character: 7}
   marks: {}
 finalState:
-  documentContents: "eee: _ @bbb @ @ccc"
+  documentContents: "eee: _ @bbb  @ccc"
   selections:
-    - anchor: {line: 0, character: 13}
-      active: {line: 0, character: 13}
+    - anchor: {line: 0, character: 12}
+      active: {line: 0, character: 12}
diff --git a/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/takeName.yml b/packages/cursorless-vscode-e2e/src/suite/fixtures/recorded/languages/scm/takeName.yml
@@ -19,5 +19,5 @@ initialState:
 finalState:
   documentContents: (aaa) @bbb @ccc @ddd
   selections:
-    - anchor: {line: 0, character: 7}
+    - anchor: {line: 0, character: 6}
       active: {line: 0, character: 20}
diff --git a/queries/scm.name.scm b/queries/scm.name.scm
@@ -1,59 +1,43 @@
 ;;!! (aaa) @bbb @ccc
-;;!         ^^^^^^^^
-;;!        xxxxxxxxx
+;;!        ^^^^^^^^^
 ;;!  ---------------
 (
   (_
     _ @dummy
     .
-    (capture
-      "@" @_.leading
-      name: (identifier) @name.start
-    )
+    (capture) @name.start
     (capture)? @name.end
     .
   ) @_.domain
   (#not-type? @_.domain parameters)
   (#not-type? @dummy capture)
   (#not-parent-type? @_.domain field_definition)
-  (#insertion-delimiter! @name.start " @")
 )
 
 ;;!! eee: (aaa) @bbb @ccc
-;;!              ^^^^^^^^
-;;!             xxxxxxxxx
+;;!             ^^^^^^^^^
 ;;!  --------------------
 (
   (field_definition
     (_
       _ @dummy
       .
-      (capture
-        "@" @_.leading
-        name: (identifier) @name.start
-      )
+      (capture) @name.start
       (capture)? @name.end
       .
     )
   ) @_.domain
   (#not-type? @dummy capture)
-  (#insertion-delimiter! @name.start " @")
 )
 
 ;;!! (aaa) @bbb @ccc
-;;!         ^^^  ^^^
-;;!        xxxx xxxx
-;;!        ---- ----
+;;!        ^^^^ ^^^^
 (
   (_
-    (capture
-      "@" @_.leading
-      name: (identifier) @name
-    ) @_.domain
+    (capture) @name
   ) @dummy
   (#not-type? @dummy parameters)
   (#has-multiple-children-of-type? @dummy capture)
-  (#insertion-delimiter! @name " @")
 )
 
 ;;!! (aaa) @bbb @ccc
