Add tests for universal serializer trait

Author: cursedcoder

EProcess/Behaviour/UniversalSerializer.php

@@ -13,13 +13,16 @@ trait UniversalSerializer
     public function serialize($data)
     {
         $pack = [];
+        $type = gettype($data);
 
         if ($data instanceof ArrayCollection) {
             $data = $data->toArray();
         } elseif (!is_array($data)) {
             $data = [$data];
         }
 
+        $data['type'] = $type;
+
         foreach ($data as $key => $piece) {
             switch (gettype($piece)) {
                 case 'object':
@@ -47,6 +50,9 @@ public function unserialize($data)
         $unpack = [];
         $data = is_array($data) ? $data : unserialize($data);
 
+        $type = unserialize($data['type']);
+        unset($data['type']);
+
         foreach ($data as $key => $piece) {
             $piece = unserialize($piece);
 
@@ -70,7 +76,7 @@ public function unserialize($data)
             }
         }
 
-        return 1 === count($unpack) ? current($unpack) : $unpack;
+        return $type !== 'array' && 1 === count($unpack) ? current($unpack) : $unpack;
     }
 
     public function findSerializer()

composer.json

@@ -21,7 +21,8 @@
   },
   "license": "MIT",
   "require-dev": {
-    "divi/pthreads-stub": "dev-master"
+    "divi/pthreads-stub": "dev-master",
+    "phpunit/phpunit": "^5.3"
   },
   "autoload": {
     "psr-4": {
@@ -30,7 +31,8 @@
   },
   "autoload-dev": {
     "psr-4": {
-      "Examples\\": "examples/"
+      "Examples\\": "examples/",
+      "Tests\\": "tests/"
     }
   }
 }

phpunit.xml.dist

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!-- http://phpunit.de/manual/4.1/en/appendixes.configuration.html -->
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.1/phpunit.xsd"
+         backupGlobals="false"
+         colors="true"
+         bootstrap="examples/autoload.php"
+>
+    <php>
+        <ini name="error_reporting" value="-1" />
+        <server name="KERNEL_DIR" value="app/" />
+    </php>
+
+    <testsuites>
+        <testsuite name="Project Test Suite">
+            <directory>tests</directory>
+        </testsuite>
+    </testsuites>
+</phpunit>

tests/EProcess/Behaviour/UniversalSerializerTest.php

@@ -0,0 +1,57 @@
+<?php
+
+namespace Tests\EProcess\Behaviour;
+
+use EProcess\Behaviour\UniversalSerializer;
+use Examples\Simple\Model\Transaction;
+
+class UniversalSerializerTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * @test
+     */
+    public function should_serialize_array()
+    {
+        $this->assertData(['abcde' => 'dbce']);
+    }
+
+    /**
+     * @test
+     */
+    public function should_serialize_scalar()
+    {
+        $this->assertData('asdasd');
+    }
+
+    /**
+     * @test
+     */
+    public function should_serialize_integer()
+    {
+        $this->assertData(5123123);
+    }
+
+    /**
+     * @test
+     */
+    public function should_serialize_object()
+    {
+        $this->assertData(new Transaction('EUR', 1235));
+    }
+
+    private function assertData($data)
+    {
+        $serializer = new SomeSerializer();
+
+        $serialized = $serializer->serialize($data);
+        $unserialized = $serializer->unserialize($serialized);
+
+        $this->assertEquals($data, $unserialized);
+    }
+}
+
+class SomeSerializer
+{
+    use UniversalSerializer;
+}
+