sh: add missing quote, drop no longer used var, fixup printf mask, shellcheck warnings

Author: vszakats

generate_fnmatch.sh

@@ -1,4 +1,4 @@
 #!/bin/bash
 
 # Redirect the output of this script to a test file.
-printf "$1\0$2\0"
+printf '%s\0%s\0' "$1" "$2"

mainline.sh

@@ -3,7 +3,7 @@
 set -ex
 
 # Save off the current folder as the build root.
-export BUILD_ROOT=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
+export BUILD_ROOT; BUILD_ROOT=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 SCRIPTDIR=${BUILD_ROOT}/scripts
 
 # Parse the options.
@@ -30,4 +30,4 @@ export CXXFLAGS="-fsanitize=address,fuzzer-no-link -stdlib=libstdc++ $FUZZ_FLAG"
 export CPPFLAGS="$FUZZ_FLAG"
 export OPENSSLFLAGS="-fno-sanitize=alignment -lstdc++"
 
-${SCRIPTDIR}/compile_target.sh ${TARGET}
+"${SCRIPTDIR}"/compile_target.sh "${TARGET}"

ossfuzz.sh

@@ -25,9 +25,7 @@
 export BUILD_ROOT=$PWD
 SCRIPTDIR=${BUILD_ROOT}/scripts
 
-. ${SCRIPTDIR}/fuzz_targets
-
-GDBDIR=/src/gdb
+. "${SCRIPTDIR}"/fuzz_targets
 
 echo "BUILD_ROOT: $BUILD_ROOT"
 echo "FUZZ_TARGETS: $FUZZ_TARGETS"
@@ -36,16 +34,16 @@ echo "FUZZ_TARGETS: $FUZZ_TARGETS"
 export CURL_SOURCE_DIR=/src/curl
 
 # Compile the fuzzers.
-${SCRIPTDIR}/compile_target.sh fuzz
+"${SCRIPTDIR}"/compile_target.sh fuzz
 
 # Zip up the seed corpus.
 scripts/create_zip.sh
 
 # Copy the fuzzers over.
 for TARGET in $FUZZ_TARGETS
 do
-  cp -v build/${TARGET} ${TARGET}_seed_corpus.zip $OUT/
+  cp -v build/"${TARGET}" "${TARGET}"_seed_corpus.zip "$OUT"/
 done
 
 # Copy dictionary and options file to $OUT.
-cp -v ossconfig/*.dict ossconfig/*.options $OUT/
+cp -v ossconfig/*.dict ossconfig/*.options "$OUT"/