sh: add missing quote, drop no longer used var, fixup printf mask, shellcheck warnings (./scripts/)

Author: vszakats

scripts/check_data.sh

@@ -11,7 +11,7 @@ then
 fi
 
 # Exit if the build root has not been defined.
-. ${SCRIPTDIR}/fuzz_targets
+. "${SCRIPTDIR}"/fuzz_targets
 
 if [[ ${DEBUG} == 1 ]]
 then
@@ -44,6 +44,7 @@ do
       PERCALL=100
     fi
 
-    find ${BUILD_ROOT}/corpora/${TARGET}/ ${EXTRA_CORPUS} -type f -print0 | xargs -0 -L${PERCALL} ${BUILD_ROOT}/build/${TARGET}
+    # shellcheck disable=SC2248
+    find "${BUILD_ROOT}/corpora/${TARGET}/" ${EXTRA_CORPUS} -type f -print0 | xargs -0 -L${PERCALL} "${BUILD_ROOT}/build/${TARGET}"
   fi
 done

scripts/compile_target.sh

@@ -24,14 +24,14 @@
 TARGET=${1:-fuzz}
 
 SCRIPTDIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
-export BUILD_ROOT=$(readlink -f "${SCRIPTDIR}/..")
+export BUILD_ROOT; BUILD_ROOT=$(readlink -f "${SCRIPTDIR}/..")
 
 # Check for GDB-specific behaviour by checking for the GDBMODE flag.
 # - Compile with -O0 so that DEBUGASSERTs can be debugged in gdb.
 if [[ -n ${GDBMODE:-} ]]
 then
-    [[ -n ${CFLAGS:-} ]] && export CFLAGS="${CFLAGS} -O0" || export CFLAGS="-O0"
-    [[ -n ${CXXFLAGS:-} ]] && export CXXFLAGS="${CXXFLAGS} -O0" || export CXXFLAGS="-O0"
+    export CFLAGS="${CFLAGS:-} -O0"
+    export CXXFLAGS="${CXXFLAGS:-} -O0"
     CMAKE_GDB_FLAG="-DBUILD_GDB=ON"
 else
     CMAKE_GDB_FLAG="-DBUILD_GDB=OFF"
@@ -58,13 +58,14 @@ echo "MAKEFLAGS: ${MAKEFLAGS}"
 
 # Create a build directory for the dependencies.
 BUILD_DIR=${BUILD_ROOT}/build
-mkdir -p ${BUILD_DIR}
+mkdir -p "${BUILD_DIR}"
 
 options=''
 command -v ninja >/dev/null 2>&1 && options+=' -G Ninja'
 
 # Compile the dependencies.
-pushd ${BUILD_DIR}
-cmake ${CMAKE_GDB_FLAG} .. ${options}
-cmake --build . --target ${TARGET} ${CMAKE_VERBOSE_FLAG}
+pushd "${BUILD_DIR}"
+# shellcheck disable=SC2086
+cmake "${CMAKE_GDB_FLAG}" .. ${options}
+cmake --build . --target "${TARGET}" ${CMAKE_VERBOSE_FLAG}
 popd

scripts/create_zip.sh

@@ -5,11 +5,11 @@ set -ex
 SCRIPTDIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 BUILD_ROOT=$(readlink -f "${SCRIPTDIR}/..")
 
-. ${SCRIPTDIR}/fuzz_targets
+. "${SCRIPTDIR}"/fuzz_targets
 
 for TARGET in ${FUZZ_TARGETS}
 do
-	pushd ${BUILD_ROOT}/corpora/${TARGET}
-	zip ../../${TARGET}_seed_corpus.zip *
-	popd
+  pushd "${BUILD_ROOT}/corpora/${TARGET}"
+  zip ../../"${TARGET}_seed_corpus.zip" *
+  popd
 done

scripts/ossfuzzdeps.sh

@@ -6,7 +6,6 @@
 # Use it to compile and install all the dependencies
 
 set -ex
-SCRIPTDIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
 
 # Work out if we need to install with sudo or not.
 if [[ $(id -u) -eq 0 ]]