Skip to content

Commit bdf9692

Browse files
committed
Revert "Remove dependency on uuid package (#284)"
This reverts commit 1ccfeea.
1 parent c2ca483 commit bdf9692

File tree

4 files changed

+37
-6
lines changed

4 files changed

+37
-6
lines changed

CHANGELOG.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
66
and this project adheres to [Semantic Versioning](http://semver.org/).
77

88
## [Unreleased]
9+
910
### Fixed
1011
- [python] Add a LICENSE file for Python ([#278](https://github.com/cucumber/messages/pull/278))
1112
- [.NET] Fix NuGet package generation
1213

13-
### Removed
14-
- [JavaScript] Remove dependency on `uuid` package ([#284](https://github.com/cucumber/messages/pull/284)
15-
1614
## [27.2.0] - 2025-01-31
1715
### Added
1816
- [python] Added Python implementation ([#165](https://github.com/cucumber/messages/pull/165))

javascript/package-lock.json

Lines changed: 30 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

javascript/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,10 @@
3636
"prepublishOnly": "npm run build && npm run copy-schemas"
3737
},
3838
"dependencies": {
39+
"@types/uuid": "10.0.0",
3940
"class-transformer": "0.5.1",
40-
"reflect-metadata": "0.2.2"
41+
"reflect-metadata": "0.2.2",
42+
"uuid": "11.0.5"
4143
},
4244
"devDependencies": {
4345
"@types/mocha": "10.0.10",

javascript/src/IdGenerator.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
import { v4 as uuidv4 } from 'uuid'
2+
13
export type NewId = () => string
24

35
export function uuid(): NewId {
4-
return () => crypto.randomUUID()
6+
return () => uuidv4()
57
}
68

79
export function incrementing(): NewId {

0 commit comments

Comments
 (0)