Use @WithLogRecordListener in tests

Author: mpkorstanje

core/src/test/java/io/cucumber/core/feature/GluePathTest.java

@@ -1,7 +1,7 @@
 package io.cucumber.core.feature;
 
 import io.cucumber.core.logging.LogRecordListener;
-import io.cucumber.core.logging.LoggerFactory;
+import io.cucumber.core.logging.WithLogRecordListener;
 import org.hamcrest.Matcher;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.condition.EnabledOnOs;
@@ -24,6 +24,7 @@
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.junit.jupiter.params.provider.Arguments.arguments;
 
+@WithLogRecordListener
 class GluePathTest {
 
     @Test
@@ -127,16 +128,11 @@ void absolute_windows_path_form_is_not_valid() {
 
     @ParameterizedTest
     @MethodSource("warn_when_glue_as_filesystem_path_examples")
-    void when_when_glue_path_is_well_known_source_directory(String gluePath, Matcher<String> logPattern) {
+    void when_when_glue_path_is_well_known_source_directory(String gluePath, Matcher<String> logPattern, LogRecordListener logRecordListener) {
         // warn when 'src/{test,main}/{java,kotlin,scala,groovy}' is used
 
-        LogRecordListener logRecordListener = new LogRecordListener();
-        LoggerFactory.addListener(logRecordListener);
-
         GluePath.parse(gluePath);
 
-        LoggerFactory.removeListener(logRecordListener);
-
         String logMessage = logRecordListener.getLogRecords()
                 .stream()
                 .findFirst()

core/src/test/java/io/cucumber/core/options/CommandlineOptionsParserTest.java

@@ -5,7 +5,6 @@
 import io.cucumber.core.gherkin.Feature;
 import io.cucumber.core.gherkin.Pickle;
 import io.cucumber.core.logging.LogRecordListener;
-import io.cucumber.core.logging.LoggerFactory;
 import io.cucumber.core.logging.WithLogRecordListener;
 import io.cucumber.core.plugin.PluginFactory;
 import io.cucumber.core.plugin.Plugins;
@@ -20,9 +19,6 @@
 import org.hamcrest.Matcher;
 import org.hamcrest.TypeSafeDiagnosingMatcher;
 import org.hamcrest.core.Is;
-import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.function.Executable;
 

core/src/test/java/io/cucumber/core/runtime/FeaturePathFeatureSupplierTest.java

@@ -4,10 +4,7 @@
 import io.cucumber.core.feature.FeaturePath;
 import io.cucumber.core.feature.Options;
 import io.cucumber.core.logging.LogRecordListener;
-import io.cucumber.core.logging.LoggerFactory;
 import io.cucumber.core.logging.WithLogRecordListener;
-import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 import java.util.Collections;