Skip to content

Commit b9308cd

Browse files
renovate[bot]renovate-botmpkorstanje
authored
Update dependency io.cucumber:ci-environment to v9 (#2475)
* Update dependency io.cucumber:ci-environment to v9 * Use new ci-environment api Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: M.P. Korstanje <rien.korstanje@gmail.com>
1 parent 6d12fde commit b9308cd

File tree

3 files changed

+13
-23
lines changed

3 files changed

+13
-23
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1010
### Added
1111

1212
### Changed
13+
* Update dependency io.cucumber:ci-environment to v9 ([#2475](https://github.com/cucumber/cucumber-jvm/pull/2475) M.P. Korstanje)
1314
* Update dependency io.cucumber:html-formatter to v18 ([#2476](https://github.com/cucumber/cucumber-jvm/pull/2476) M.P. Korstanje)
1415
- Removed work around for 'Uncaught TypeError: e.git is undefined'
1516

bom/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
<name>Cucumber-JVM: Bill of Materials</name>
1313

1414
<properties>
15-
<ci-environment.version>8.1.0</ci-environment.version>
15+
<ci-environment.version>9.0.0</ci-environment.version>
1616
<cucumber-expressions.version>15.0.1</cucumber-expressions.version>
1717
<datatable.version>4.1.0</datatable.version>
1818
<html-formatter.version>18.0.0</html-formatter.version>

core/src/main/java/io/cucumber/core/runtime/CucumberExecutionContext.java

Lines changed: 11 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.cucumber.core.runtime;
22

3-
import io.cucumber.cienvironment.CiEnvironment;
43
import io.cucumber.core.eventbus.EventBus;
54
import io.cucumber.core.gherkin.Feature;
65
import io.cucumber.core.logging.Logger;
@@ -65,27 +64,17 @@ private Meta createMeta() {
6564
new Product(System.getProperty("java.vm.name"), System.getProperty("java.vm.version")),
6665
new Product(System.getProperty("os.name"), null),
6766
new Product(System.getProperty("os.arch"), null),
68-
createCi());
69-
}
70-
71-
private Ci createCi() {
72-
CiEnvironment ciEnvironment = detectCiEnvironment(System.getenv());
73-
if (ciEnvironment == null) {
74-
return null;
75-
}
76-
77-
return new Ci(
78-
ciEnvironment.getName(),
79-
ciEnvironment.getUrl(),
80-
ciEnvironment.getBuildNumber(),
81-
createGit(ciEnvironment.getGit()));
82-
}
83-
84-
private Git createGit(CiEnvironment.Git ciGit) {
85-
if (ciGit == null) {
86-
return null;
87-
}
88-
return new Git(ciGit.getRemote(), ciGit.getRevision(), ciGit.getBranch(), ciGit.getTag());
67+
detectCiEnvironment(System.getenv()).map(ci -> new Ci(
68+
ci.getName(),
69+
ci.getUrl(),
70+
ci.getBuildNumber().orElse(null),
71+
ci.getGit().map(git -> new Git(
72+
git.getRemote(),
73+
git.getRevision(),
74+
git.getBranch().orElse(null),
75+
git.getTag().orElse(null)))
76+
.orElse(null)))
77+
.orElse(null));
8978
}
9079

9180
private void emitTestRunStarted() {

0 commit comments

Comments
 (0)