File tree Expand file tree Collapse file tree 3 files changed +9
-2
lines changed
cucumber-picocontainer/src
main/java/io/cucumber/picocontainer
test/java/io/cucumber/picocontainer Expand file tree Collapse file tree 3 files changed +9
-2
lines changed Original file line number Diff line number Diff line change @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1414- [ Core] Fixed ` cucumber.publish.enabled=false ` ([ #2747 ] ( https://github.com/cucumber/cucumber-jvm/pull/2747 ) M.P. Korstanje)
1515- [ JUnit Platform Engine] Fixed ` cucumber.publish.enabled=false ` ([ #2747 ] ( https://github.com/cucumber/cucumber-jvm/pull/2747 ) M.P. Korstanje)
1616- [ Java] Fixed duplicate step definition for classes with interfaces ([ #2757 ] ( https://github.com/cucumber/cucumber-jvm/issues/2757 ) Julien Kronegg)
17+ - [ Pico] Fixed unsatisfiable dependency with disposables ([ #2762 ] ( https://github.com/cucumber/cucumber-jvm/issues/2762 ) Julien Kronegg)
1718
1819## [ 7.12.0] - 2023-04-29
1920### Added
Original file line number Diff line number Diff line change @@ -43,8 +43,8 @@ public void stop() {
4343 @ Override
4444 public boolean addClass (Class <?> clazz ) {
4545 if (isInstantiable (clazz ) && classes .add (clazz )) {
46- pico .addComponent (clazz );
4746 addConstructorDependencies (clazz );
47+ pico .addComponent (clazz );
4848 }
4949 return true ;
5050 }
Original file line number Diff line number Diff line change 11package io .cucumber .picocontainer ;
22
3+ import org .picocontainer .Disposable ;
4+
35public class StepDefinitionsWithTransitiveDependencies {
46
57 final FirstDependency firstDependency ;
@@ -8,12 +10,16 @@ public StepDefinitionsWithTransitiveDependencies(FirstDependency firstDependency
810 this .firstDependency = firstDependency ;
911 }
1012
11- public static class FirstDependency {
13+ public static class FirstDependency implements Disposable {
1214 final SecondDependency secondDependency ;
1315
1416 public FirstDependency (SecondDependency secondDependency ) {
1517 this .secondDependency = secondDependency ;
1618 }
19+
20+ @ Override
21+ public void dispose () {
22+ }
1723 }
1824
1925 public static class SecondDependency {
You can’t perform that action at this time.
0 commit comments