Use Github release automation (#2500)

Co-authored-by: M.P. Korstanje <rien.korstanje@gmail.com>

Author: mattwynne

.github/workflows/release-github.yml

@@ -0,0 +1,9 @@
+name: Release on GitHub
+
+on:
+  push:
+    branches: [release/*]
+
+jobs:
+  pre-release-check:
+    uses: cucumber/.github/.github/workflows/prerelease-checks.yml@main

.github/workflows/release-java.yml

@@ -0,0 +1,34 @@
+name: Release maven package
+
+on:
+  push:
+    branches: [release/*]
+
+jobs:
+  pre-release-check:
+    uses: cucumber/.github/.github/workflows/prerelease-checks.yml@main
+
+  test-java:
+    uses: ./.github/workflows/test-java.yml
+
+  publish-mvn:
+    name: Publish Maven Package
+    needs: [pre-release-check, test-java]
+    runs-on: ubuntu-latest
+    environment: Release
+
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: actions/setup-java@v2
+        with:
+          distribution: "temurin"
+          java-version: "11"
+          cache: "maven"
+
+      - uses: cucumber/action-publish-mvn@v1.1.0
+        with:
+          gpg-private-key: ${{ secrets.GPG_PRIVATE_KEY }}
+          gpg-passphrase: ${{ secrets.GPG_PASSPHRASE }}
+          nexus-username: cukebot
+          nexus-password: ${{ secrets.SONATYPE_PASSWORD }}

.github/workflows/build.yml renamed to .github/workflows/test-java.yml

@@ -1,6 +1,7 @@
-name: Cucumber CI
+name: Test java
 
 on:
+  workflow_call:
   push:
   pull_request:
     branches:

Makefile

@@ -49,32 +49,7 @@ update-changelog:
 	git push
 .PHONY: .commit-and-push-changelog
 
-.configure-cukebot-in-docker:
-	[ -f '/home/cukebot/configure' ] && /home/cukebot/configure
-.PHONY: .configure-cukebot-in-docker
-
-.release-in-docker: .configure-cukebot-in-docker default update-changelog .commit-and-push-changelog
+release: default update-changelog .commit-and-push-changelog
 	mvn --batch-mode release:clean release:prepare -DautoVersionSubmodules=true -Darguments="-DskipTests=true -DskipITs=true -Darchetype.test.skip=true"
-	git checkout "v$(NEW_VERSION)"
-	mvn deploy -P-examples -P-compatibility -Psign-source-javadoc -DskipTests=true -DskipITs=true -Darchetype.test.skip=true
-	git checkout $(CURRENT_BRANCH)
-	git fetch
-.PHONY: .release-in-docker
-
-release:
-	[ -d '../secrets' ]  || git clone keybase://team/cucumberbdd/secrets ../secrets
-	git -C ../secrets pull
-	../secrets/update_permissions
-	docker run \
-	  --volume "${shell pwd}":/app \
- 	  --volume "${shell pwd}/../secrets/configure":/home/cukebot/configure \
-	  --volume "${shell pwd}/../secrets/codesigning.key":/home/cukebot/codesigning.key \
-	  --volume "${shell pwd}/../secrets/gpg-with-passphrase":/home/cukebot/gpg-with-passphrase \
-	  --volume "${shell pwd}/../secrets/.ssh":/home/cukebot/.ssh \
-	  --volume "${HOME}/.m2/repository":/home/cukebot/.m2/repository \
-	  --env-file "${shell pwd}/../secrets/secrets.list" \
-	  --user 1000 \
-	  --rm \
-	  -it cucumber/cucumber-build:0.1.0@sha256:2ce049493dfadad62b78594e6728d1f85ccc5a2441b5a8b3f7a106a7bba39ec1 \
-	  make .release-in-docker
+	git push origin $$(git rev-list --max-count=1 v$(NEW_VERSION)):refs/heads/release/v$(NEW_VERSION)
 .PHONY: release

RELEASING.md

@@ -43,28 +43,26 @@ Check if branch name and version are as expected. To change version run:
 mvn versions:set -DnewVersion=X.Y.Z-SNAPSHOT
 ```
 
-## Secrets ##
-
-Secrets are required to make releases. Members of the core team can install
-keybase and join the `cucumberbdd` team to access these secrets.
-
-During the release process, secrets are fetched from keybase and used to sign
-and upload the maven artifacts.
-
 ## Make the release ##
 
-Check if branch name and version are as expected:
+Only people with permission to push to `release/*` branches can make releases.
+
+1. Check if branch name and version are as expected:
 
 ```
 make version
 ```
 
-Do the release:
+2. Do the release:
 
 ```
 make release
 ``` 
 
+3. Wait until the `release-*` workflows have passed for the new release branch:
+  * [![Release maven package](https://github.com/cucumber/cucumber-jvm/actions/workflows/release-java.yml/badge.svg)](https://github.com/cucumber/cucumber-jvm/actions/workflows/release-java.yml)
+  * [![Release on GitHub](https://github.com/cucumber/cucumber-jvm/actions/workflows/release-github.yml/badge.svg)](https://github.com/cucumber/cucumber-jvm/actions/workflows/release-github.yml)
+
 ## Last bits ##
 
 Update the cucumber-jvm version in the documentation project:
@@ -74,3 +72,5 @@ Update the cucumber-jvm version in the documentation project:
 The cucumber-jvm version for the docs is specified in the docs [versions.yaml](https://github.com/cucumber/docs.cucumber.io/blob/master/data/versions.yaml)
 
 All done! Hurray!
+
+[changelog]: https://github.com/cucumber/changelog#installation