Add failing tests for isolation and objects

gaeljw · gaeljw · commit 79f4ac2a6bd7 · 2020-05-01T11:36:50.000+02:00
diff --git a/scala/sources/src/test/resources/tests/cukes/cukes.feature b/scala/sources/src/test/resources/tests/cukes/cukes.feature
diff --git a/scala/sources/src/test/resources/tests/isolated/isolated.feature b/scala/sources/src/test/resources/tests/isolated/isolated.feature
@@ -0,0 +1,12 @@
+Feature: Isolated
+
+  Scenario: First test
+    Given I set the list of values to
+      | 1 |
+      | 2 |
+      | 3 |
+    And I multiply by 2
+    Then the list of values is
+      | 2 |
+      | 4 |
+      | 6 |
diff --git a/scala/sources/src/test/resources/tests/isolated/isolated2.feature b/scala/sources/src/test/resources/tests/isolated/isolated2.feature
@@ -0,0 +1,8 @@
+Feature: Isolated 2
+
+  Scenario: Second test
+    Given I set the list of values to
+      | 10 |
+    And I multiply by 2
+    Then the list of values is
+      | 20 |
diff --git a/scala/sources/src/test/resources/tests/object/object.feature b/scala/sources/src/test/resources/tests/object/object.feature
@@ -0,0 +1,11 @@
+Feature: As Cucumber Scala, I want to be able to use steps defined in objects even though they will persist their state across scenarios
+
+  Scenario: First scenario
+    Given I have a calculator
+    When I do 2 + 2
+    Then I got 4
+
+  Scenario: Second scenario
+    Given I have a calculator
+    When I do 5 + 6
+    Then I got 11
diff --git a/scala/sources/src/test/scala/tests/cukes/RunCukesTest.scala b/scala/sources/src/test/scala/tests/cukes/RunCukesTest.scala
@@ -1,4 +1,4 @@
-package tests
+package tests.cukes
 
 import io.cucumber.junit.{Cucumber, CucumberOptions}
 import org.junit.runner.RunWith
diff --git a/scala/sources/src/test/scala/tests/cukes/StepDefs.scala b/scala/sources/src/test/scala/tests/cukes/StepDefs.scala
@@ -1,11 +1,11 @@
-package tests
+package tests.cukes
 
 import java.util.{List => JList, Map => JMap}
 
 import io.cucumber.datatable.DataTable
 import io.cucumber.scala.{EN, ScalaDsl}
 import junit.framework.Assert._
-import tests.model.{Cukes, Person, Snake}
+import tests.cukes.model.{Cukes, Person, Snake}
 
 import scala.collection.JavaConverters._
 
diff --git a/scala/sources/src/test/scala/tests/cukes/TypeRegistryConfiguration.scala b/scala/sources/src/test/scala/tests/cukes/TypeRegistryConfiguration.scala
@@ -1,4 +1,4 @@
-package tests
+package tests.cukes
 
 import java.lang.reflect.Type
 import java.util
@@ -8,7 +8,7 @@ import com.fasterxml.jackson.databind.ObjectMapper
 import io.cucumber.core.api.{TypeRegistry, TypeRegistryConfigurer}
 import io.cucumber.cucumberexpressions.{ParameterByTypeTransformer, ParameterType, Transformer}
 import io.cucumber.datatable.{DataTableType, TableCellByTypeTransformer, TableEntryByTypeTransformer, TableEntryTransformer}
-import tests.model.{Cukes, Person, Snake}
+import tests.cukes.model.{Cukes, Person, Snake}
 
 class TypeRegistryConfiguration extends TypeRegistryConfigurer {
 
diff --git a/scala/sources/src/test/scala/tests/cukes/model/Cuke.scala b/scala/sources/src/test/scala/tests/cukes/model/Cuke.scala
@@ -1,3 +1,3 @@
-package tests.model
+package tests.cukes.model
 
 case class Cukes(number: Int, color: String)
diff --git a/scala/sources/src/test/scala/tests/cukes/model/Person.scala b/scala/sources/src/test/scala/tests/cukes/model/Person.scala
@@ -1,4 +1,4 @@
-package tests.model
+package tests.cukes.model
 
 /**
  * Test model for a "Person"
diff --git a/scala/sources/src/test/scala/tests/cukes/model/Snake.scala b/scala/sources/src/test/scala/tests/cukes/model/Snake.scala
@@ -1,4 +1,4 @@
-package tests.model
+package tests.cukes.model
 
 /**
  * Test model "Snake" to exercise the custom mapper functionality
diff --git a/scala/sources/src/test/scala/tests/isolated/IsolatedSteps.scala b/scala/sources/src/test/scala/tests/isolated/IsolatedSteps.scala
@@ -0,0 +1,26 @@
+package tests.isolated
+
+import java.util.{List => JList}
+import io.cucumber.scala.{EN, ScalaDsl}
+
+import scala.collection.JavaConverters._
+
+class IsolatedSteps extends ScalaDsl with EN {
+
+  var mutableValues: List[Int] = List()
+
+  Given("""I set the list of values to""") { (values: JList[Int]) =>
+    // Obviously this is silly, as we keep the previous value but this is exactly what we want to test
+    // Isolated scenarios should ensure that the previous value is not kept
+    mutableValues = mutableValues ++ values.asScala.toList
+  }
+
+  Given("""I multiply by {int}""") { (mult: Int) =>
+    mutableValues = mutableValues.map(i => i * mult)
+  }
+
+  Then("""the list of values is""") { (values: JList[Int]) =>
+    assert(mutableValues == values.asScala.toList)
+  }
+
+}
diff --git a/scala/sources/src/test/scala/tests/isolated/RunIsolatedTest.scala b/scala/sources/src/test/scala/tests/isolated/RunIsolatedTest.scala
@@ -0,0 +1,8 @@
+package tests.isolated
+
+import io.cucumber.junit.{Cucumber, CucumberOptions}
+import org.junit.runner.RunWith
+
+@RunWith(classOf[Cucumber])
+@CucumberOptions(strict = true)
+class RunIsolatedTest
diff --git a/scala/sources/src/test/scala/tests/object/ObjectSteps.scala b/scala/sources/src/test/scala/tests/object/ObjectSteps.scala
@@ -0,0 +1,27 @@
+package tests.`object`
+
+import io.cucumber.scala.{EN, ScalaDsl}
+import org.junit.Assert.assertEquals
+
+object ObjectSteps extends ScalaDsl with EN {
+
+  private var calculator: Calculator = _
+  private var result: Int = -1
+
+  Given("""I have a calculator""") {
+    calculator = new Calculator()
+  }
+
+  When("""I do {int} + {int}""") { (a: Int, b: Int) =>
+    result = calculator.add(a, b)
+  }
+
+  Then("""I got {int}""") { (expectedResult: Int) =>
+    assertEquals(expectedResult, result)
+  }
+
+  private class Calculator {
+    def add(a: Int, b: Int) = a + b
+  }
+
+}
diff --git a/scala/sources/src/test/scala/tests/object/RunObjectTest.scala b/scala/sources/src/test/scala/tests/object/RunObjectTest.scala
@@ -0,0 +1,8 @@
+package tests.`object`
+
+import io.cucumber.junit.{Cucumber, CucumberOptions}
+import org.junit.runner.RunWith
+
+@RunWith(classOf[Cucumber])
+@CucumberOptions(strict = true)
+class RunObjectTest

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-package tests`
	`1`	`+package tests.cukes`
`2`	`2`
`3`	`3`	`import io.cucumber.junit.{Cucumber, CucumberOptions}`
`4`	`4`	`import org.junit.runner.RunWith`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`		`-package tests.model`
	`1`	`+package tests.cukes.model`
`2`	`2`
`3`	`3`	`case class Cukes(number: Int, color: String)`