lint

Author: waralexrom

rust/cubesqlplanner/cubesqlplanner/src/test_fixtures/cube_bridge/mock_base_tools.rs

@@ -6,7 +6,7 @@ use crate::cube_bridge::pre_aggregation_obj::PreAggregationObj;
 use crate::cube_bridge::sql_templates_render::SqlTemplatesRender;
 use crate::cube_bridge::sql_utils::SqlUtils;
 use crate::test_fixtures::cube_bridge::{
-    MockDriverTools, MockJoinGraph, MockSecurityContext, MockSqlTemplatesRender, MockSqlUtils,
+    MockDriverTools, MockJoinGraph, MockSqlTemplatesRender, MockSqlUtils,
 };
 use cubenativeutils::CubeError;
 use std::any::Any;

rust/cubesqlplanner/cubesqlplanner/src/test_fixtures/cube_bridge/mock_schema.rs

@@ -2,7 +2,6 @@ use crate::test_fixtures::cube_bridge::yaml::YamlSchema;
 use crate::test_fixtures::cube_bridge::{
     MockBaseTools, MockCubeDefinition, MockCubeEvaluator, MockDimensionDefinition, MockDriverTools,
     MockJoinGraph, MockJoinItemDefinition, MockMeasureDefinition, MockSegmentDefinition,
-    MockSqlTemplatesRender,
 };
 use cubenativeutils::CubeError;
 use std::collections::HashMap;

rust/cubesqlplanner/cubesqlplanner/src/test_fixtures/cube_bridge/mod.rs

@@ -48,7 +48,7 @@ pub use mock_expression_struct::MockExpressionStruct;
 pub use mock_geo_item::MockGeoItem;
 pub use mock_granularity_definition::MockGranularityDefinition;
 pub use mock_join_definition::MockJoinDefinition;
-pub use mock_join_graph::{JoinEdge, MockJoinGraph};
+pub use mock_join_graph::MockJoinGraph;
 pub use mock_join_item::MockJoinItem;
 pub use mock_join_item_definition::MockJoinItemDefinition;
 pub use mock_measure_definition::MockMeasureDefinition;

rust/cubesqlplanner/cubesqlplanner/src/test_fixtures/cube_bridge/yaml/dimension.rs

@@ -1,7 +1,7 @@
 use crate::cube_bridge::case_variant::CaseVariant;
 use crate::test_fixtures::cube_bridge::yaml::case::YamlCaseVariant;
 use crate::test_fixtures::cube_bridge::yaml::timeshift::YamlTimeShiftDefinition;
-use crate::test_fixtures::cube_bridge::{MockDimensionDefinition, MockTimeShiftDefinition};
+use crate::test_fixtures::cube_bridge::MockDimensionDefinition;
 use serde::Deserialize;
 use std::rc::Rc;
 
@@ -33,10 +33,6 @@ pub struct YamlDimensionDefinition {
     time_shift: Vec<YamlTimeShiftDefinition>,
 }
 
-fn default_dimension_type() -> String {
-    "string".to_string()
-}
-
 impl YamlDimensionDefinition {
     pub fn build(self) -> Rc<MockDimensionDefinition> {
         let time_shift = if !self.time_shift.is_empty() {

rust/cubesqlplanner/cubesqlplanner/src/test_fixtures/cube_bridge/yaml/mod.rs

@@ -5,9 +5,7 @@ pub mod schema;
 pub mod segment;
 pub mod timeshift;
 
-pub use case::{YamlCaseDefinition, YamlCaseSwitchDefinition, YamlCaseVariant};
 pub use dimension::YamlDimensionDefinition;
 pub use measure::YamlMeasureDefinition;
 pub use schema::YamlSchema;
 pub use segment::YamlSegmentDefinition;
-pub use timeshift::YamlTimeShiftDefinition;

rust/cubesqlplanner/cubesqlplanner/src/test_fixtures/test_utils/test_context.rs

@@ -13,12 +13,10 @@ pub struct TestContext {
 }
 
 impl TestContext {
-    /// Creates new test context from a mock schema with UTC timezone
     pub fn new(schema: MockSchema) -> Result<Self, CubeError> {
         Self::new_with_timezone(schema, Tz::UTC)
     }
 
-    /// Creates new test context from a mock schema with specific timezone
     pub fn new_with_timezone(schema: MockSchema, timezone: Tz) -> Result<Self, CubeError> {
         let base_tools = schema.create_base_tools()?;
         let join_graph = Rc::new(schema.create_join_graph()?);
@@ -38,36 +36,33 @@ impl TestContext {
         Ok(Self { query_tools })
     }
 
-    /// Returns reference to query tools
+    #[allow(dead_code)]
     pub fn query_tools(&self) -> &Rc<QueryTools> {
         &self.query_tools
     }
 
-    /// Creates a symbol from cube.member path
+    #[allow(dead_code)]
     pub fn create_symbol(&self, member_path: &str) -> Result<Rc<MemberSymbol>, CubeError> {
         self.query_tools
             .evaluator_compiler()
             .borrow_mut()
             .add_auto_resolved_member_evaluator(member_path.to_string())
     }
 
-    /// Creates a dimension symbol from cube.dimension path
     pub fn create_dimension(&self, path: &str) -> Result<Rc<MemberSymbol>, CubeError> {
         self.query_tools
             .evaluator_compiler()
             .borrow_mut()
             .add_dimension_evaluator(path.to_string())
     }
 
-    /// Creates a measure symbol from cube.measure path
     pub fn create_measure(&self, path: &str) -> Result<Rc<MemberSymbol>, CubeError> {
         self.query_tools
             .evaluator_compiler()
             .borrow_mut()
             .add_measure_evaluator(path.to_string())
     }
 
-    /// Evaluates a symbol to SQL string
     pub fn evaluate_symbol(&self, symbol: &Rc<MemberSymbol>) -> Result<String, CubeError> {
         let visitor = SqlEvaluatorVisitor::new(self.query_tools.clone(), None);
         let base_tools = self.query_tools.base_tools();