Fix clippy by avoiding deprecated functions in chrono (apache#4189)

* Fix clippy by avoiding deprecated functions in chrono

* Fixup

Author: alamb

datafusion/core/src/datasource/listing/helpers.rs

@@ -348,7 +348,9 @@ fn batches_to_paths(batches: &[RecordBatch]) -> Vec<PartitionedFile> {
             (0..batch.num_rows()).map(move |row| PartitionedFile {
                 file_meta: FileMeta {
                     last_modified: match modified_array.is_null(row) {
-                        false => Some(Utc.timestamp_millis(modified_array.value(row))),
+                        false => {
+                            Some(to_timestamp_millis(modified_array.value(row)).unwrap())
+                        }
                         true => None,
                     },
                     sized_file: SizedFile {
@@ -366,6 +368,20 @@ fn batches_to_paths(batches: &[RecordBatch]) -> Vec<PartitionedFile> {
         .collect()
 }
 
+fn to_timestamp_millis(v: i64) -> Result<chrono::DateTime<Utc>> {
+    match Utc.timestamp_millis_opt(v) {
+        chrono::LocalResult::None => Err(DataFusionError::Execution(format!(
+            "Can not convert {} to UTC millisecond timestamp",
+            v
+        ))),
+        chrono::LocalResult::Single(v) => Ok(v),
+        chrono::LocalResult::Ambiguous(_, _) => Err(DataFusionError::Execution(format!(
+            "Ambiguous timestamp when converting {} to UTC millisecond timestamp",
+            v
+        ))),
+    }
+}
+
 /// Extract the partition values for the given `file_path` (in the given `table_path`)
 /// associated to the partitions defined by `table_partition_cols`
 fn parse_partitions_for_path<'a>(
@@ -649,7 +665,7 @@ mod tests {
                     path: String::from("mybucket/tablepath/part1=val1/file.parquet"),
                     size: 100,
                 },
-                last_modified: Some(Utc.timestamp_millis(1634722979123)),
+                last_modified: Some(to_timestamp_millis(1634722979123).unwrap()),
             },
             FileMeta {
                 sized_file: SizedFile {
@@ -683,7 +699,7 @@ mod tests {
                     path: String::from("mybucket/tablepath/part1=val1/file.parquet"),
                     size: 100,
                 },
-                last_modified: Some(Utc.timestamp_millis(1634722979123)),
+                last_modified: Some(to_timestamp_millis(1634722979123).unwrap()),
             },
             FileMeta {
                 sized_file: SizedFile {

datafusion/core/tests/parquet_pruning.rs

@@ -120,7 +120,7 @@ async fn prune_date64() {
     let date = "2020-01-02"
         .parse::<chrono::NaiveDate>()
         .unwrap()
-        .and_time(chrono::NaiveTime::from_hms(0, 0, 0));
+        .and_time(chrono::NaiveTime::from_hms_opt(0, 0, 0).unwrap());
     let date = ScalarValue::Date64(Some(date.timestamp_millis()));
 
     let output = ContextWithParquet::new(Scenario::Dates)
@@ -801,7 +801,7 @@ fn make_date_batch(offset: Duration) -> RecordBatch {
                 let t = t
                     .parse::<chrono::NaiveDate>()
                     .unwrap()
-                    .and_time(chrono::NaiveTime::from_hms(0, 0, 0));
+                    .and_time(chrono::NaiveTime::from_hms_opt(0, 0, 0).unwrap());
                 let t = t + offset;
                 t.timestamp_millis()
             })

datafusion/core/tests/sql/timestamp.rs

@@ -780,7 +780,7 @@ async fn group_by_timestamp_millis() -> Result<()> {
         ),
         Field::new("count", DataType::Int32, false),
     ]));
-    let base_dt = Utc.ymd(2018, 7, 1).and_hms(6, 0, 0); // 2018-Jul-01 06:00
+    let base_dt = Utc.with_ymd_and_hms(2018, 7, 1, 6, 0, 0).unwrap(); // 2018-Jul-01 06:00
     let hour1 = Duration::hours(1);
     let timestamps = vec![
         base_dt.timestamp_millis(),