iavf: Fix a locking bug in an error path

JIRA: https://issues.redhat.com/browse/RHEL-87382

commit e589adf
Author: Bart Van Assche <bvanassche@acm.org>
Date:   Thu Feb 6 09:51:08 2025 -0800

    iavf: Fix a locking bug in an error path

    If the netdev lock has been obtained, unlock it before returning.
    This bug has been detected by the Clang thread-safety analyzer.

    Fixes: afc6649 ("eth: iavf: extend the netdev_lock usage")
    Signed-off-by: Bart Van Assche <bvanassche@acm.org>
    Link: https://patch.msgid.link/20250206175114.1974171-28-bvanassche@acm.org
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Signed-off-by: Mohammad Heib <mheib@redhat.com>

Author: mohammadheib

drivers/net/ethernet/intel/iavf/iavf_main.c

@@ -3083,8 +3083,8 @@ static void iavf_watchdog_task(struct work_struct *work)
 	}
 
 	mutex_unlock(&adapter->crit_lock);
-	netdev_unlock(netdev);
 restart_watchdog:
+	netdev_unlock(netdev);
 	if (adapter->state >= __IAVF_DOWN)
 		queue_work(adapter->wq, &adapter->adminq_task);
 	if (adapter->aq_required)