Skip to content

Commit fe2ea10

Browse files
committed
drivers/platform/mellanox: Convert snprintf to sysfs_emit
JIRA: https://issues.redhat.com/browse/RHEL-45234 commit e5afa3d Author: Li Zhijian <lizhijian@fujitsu.com> Date: Tue, 16 Jan 2024 12:51:23 +0800 Per filesystems/sysfs.rst, show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. coccinelle complains that there are still a couple of functions that use snprintf(). Convert them to sysfs_emit(). > ./drivers/platform/mellanox/mlxbf-bootctl.c:466:8-16: WARNING: please use sysfs_emit > ./drivers/platform/mellanox/mlxbf-bootctl.c:584:8-16: WARNING: please use sysfs_emit > ./drivers/platform/mellanox/mlxbf-bootctl.c:635:8-16: WARNING: please use sysfs_emit > ./drivers/platform/mellanox/mlxbf-bootctl.c:686:8-16: WARNING: please use sysfs_emit > ./drivers/platform/mellanox/mlxbf-bootctl.c:737:8-16: WARNING: please use sysfs_emit > ./drivers/platform/mellanox/mlxbf-bootctl.c:788:8-16: WARNING: please use sysfs_emit > ./drivers/platform/mellanox/mlxbf-bootctl.c:839:8-16: WARNING: please use sysfs_emit No functional change intended Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> Link: https://lore.kernel.org/r/20240116045151.3940401-12-lizhijian@fujitsu.com Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
1 parent e58b1ae commit fe2ea10

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/platform/mellanox/mlxbf-bootctl.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ static ssize_t large_icm_show(struct device *dev,
463463
if (res.a0)
464464
return -EPERM;
465465

466-
return snprintf(buf, PAGE_SIZE, "0x%lx", res.a1);
466+
return sysfs_emit(buf, "0x%lx", res.a1);
467467
}
468468

469469
static ssize_t large_icm_store(struct device *dev,
@@ -581,7 +581,7 @@ static ssize_t opn_show(struct device *dev,
581581
}
582582
mutex_unlock(&mfg_ops_lock);
583583

584-
return snprintf(buf, PAGE_SIZE, "%s", (char *)opn_data);
584+
return sysfs_emit(buf, "%s", (char *)opn_data);
585585
}
586586

587587
static ssize_t opn_store(struct device *dev,
@@ -632,7 +632,7 @@ static ssize_t sku_show(struct device *dev,
632632
}
633633
mutex_unlock(&mfg_ops_lock);
634634

635-
return snprintf(buf, PAGE_SIZE, "%s", (char *)sku_data);
635+
return sysfs_emit(buf, "%s", (char *)sku_data);
636636
}
637637

638638
static ssize_t sku_store(struct device *dev,
@@ -683,7 +683,7 @@ static ssize_t modl_show(struct device *dev,
683683
}
684684
mutex_unlock(&mfg_ops_lock);
685685

686-
return snprintf(buf, PAGE_SIZE, "%s", (char *)modl_data);
686+
return sysfs_emit(buf, "%s", (char *)modl_data);
687687
}
688688

689689
static ssize_t modl_store(struct device *dev,
@@ -734,7 +734,7 @@ static ssize_t sn_show(struct device *dev,
734734
}
735735
mutex_unlock(&mfg_ops_lock);
736736

737-
return snprintf(buf, PAGE_SIZE, "%s", (char *)sn_data);
737+
return sysfs_emit(buf, "%s", (char *)sn_data);
738738
}
739739

740740
static ssize_t sn_store(struct device *dev,
@@ -785,7 +785,7 @@ static ssize_t uuid_show(struct device *dev,
785785
}
786786
mutex_unlock(&mfg_ops_lock);
787787

788-
return snprintf(buf, PAGE_SIZE, "%s", (char *)uuid_data);
788+
return sysfs_emit(buf, "%s", (char *)uuid_data);
789789
}
790790

791791
static ssize_t uuid_store(struct device *dev,
@@ -836,7 +836,7 @@ static ssize_t rev_show(struct device *dev,
836836
}
837837
mutex_unlock(&mfg_ops_lock);
838838

839-
return snprintf(buf, PAGE_SIZE, "%s", (char *)rev_data);
839+
return sysfs_emit(buf, "%s", (char *)rev_data);
840840
}
841841

842842
static ssize_t rev_store(struct device *dev,

0 commit comments

Comments
 (0)