ASoC: qdsp6: q6asm: do not sleep while atomic

Srinivas Kandagatla · broonie · commit fdbb53d318aa · 2025-10-20T02:39:17.000+01:00
For some reason we ended up kfree between spinlock lock and unlock, which can sleep. move the kfree out of spinlock section. Fixes: a2a5d30 ("ASoC: qdsp6: q6asm: Add support to memory map and unmap") Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Link: https://patch.msgid.link/20251017085307.4325-2-srinivas.kandagatla@oss.qualcomm.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/qcom/qdsp6/q6asm.c b/sound/soc/qcom/qdsp6/q6asm.c
@@ -377,9 +377,9 @@ static void q6asm_audio_client_free_buf(struct audio_client *ac,
 
 	spin_lock_irqsave(&ac->lock, flags);
 	port->num_periods = 0;
+	spin_unlock_irqrestore(&ac->lock, flags);
 	kfree(port->buf);
 	port->buf = NULL;
-	spin_unlock_irqrestore(&ac->lock, flags);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -377,9 +377,9 @@ static void q6asm_audio_client_free_buf(struct audio_client *ac,`
`377`	`377`
`378`	`378`	`spin_lock_irqsave(&ac->lock, flags);`
`379`	`379`	`port->num_periods = 0;`
	`380`	`+ spin_unlock_irqrestore(&ac->lock, flags);`
`380`	`381`	`kfree(port->buf);`
`381`	`382`	`port->buf = NULL;`
`382`		`- spin_unlock_irqrestore(&ac->lock, flags);`
`383`	`383`	`}`
`384`	`384`
`385`	`385`	`/**`