Skip to content

Commit fc2ac2d

Browse files
author
Izabela Bakollari
committed
net: phy: dp83822: Fix reset pin definitions
JIRA: https://issues.redhat.com/browse/RHEL-57766 commit de96f6a Author: Michel Alex <Alex.Michel@wiedemann-group.com> Date: Wed Oct 16 12:11:15 2024 +0000 net: phy: dp83822: Fix reset pin definitions This change fixes a rare issue where the PHY fails to detect a link due to incorrect reset behavior. The SW_RESET definition was incorrectly assigned to bit 14, which is the Digital Restart bit according to the datasheet. This commit corrects SW_RESET to bit 15 and assigns DIG_RESTART to bit 14 as per the datasheet specifications. The SW_RESET define is only used in the phy_reset function, which fully re-initializes the PHY after the reset is performed. The change in the bit definitions should not have any negative impact on the functionality of the PHY. v2: - added Fixes tag - improved commit message Cc: stable@vger.kernel.org Fixes: 5dc39fd ("net: phy: DP83822: Add ability to advertise Fiber connection") Signed-off-by: Alex Michel <alex.michel@wiedemann-group.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Message-ID: <AS1P250MB0608A798661549BF83C4B43EA9462@AS1P250MB0608.EURP250.PROD.OUTLOOK.COM> Signed-off-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Izabela Bakollari <ibakolla@redhat.com>
1 parent 38278ac commit fc2ac2d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/phy/dp83822.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@
4545
/* Control Register 2 bits */
4646
#define DP83822_FX_ENABLE BIT(14)
4747

48-
#define DP83822_HW_RESET BIT(15)
49-
#define DP83822_SW_RESET BIT(14)
48+
#define DP83822_SW_RESET BIT(15)
49+
#define DP83822_DIG_RESTART BIT(14)
5050

5151
/* PHY STS bits */
5252
#define DP83822_PHYSTS_DUPLEX BIT(2)

0 commit comments

Comments
 (0)