Skip to content

Commit fa963f8

Browse files
committed
perf test: Remove cpu-list BPF cgroup counter test
JIRA: https://issues.redhat.com/browse/RHEL-33006 upstream ======== commit c741c7b Author: Michael Petlan <mpetlan@redhat.com> Date: Fri Nov 1 11:28:12 2024 +0100 description =========== The cpu-list part of this testcase has proven itself to be unreliable. Sometimes, we get "<not counted>" for system.slice when pinned to CPUs 0 and 1. In such case, the test fails. Since we cannot simply guarantee that any system.slice load will run on any arbitrary list of CPUs, except the whole set of all CPUs, let's rather remove the cpu-list subtest. Fixes: a84260e ("perf test stat_bpf_counters_cgrp: Enhance perf stat cgroup BPF counter test") Signed-off-by: Michael Petlan <mpetlan@redhat.com> Cc: vmolnaro@redhat.com Cc: bpf@vger.kernel.org Link: https://lore.kernel.org/r/20241101102812.576425-1-mpetlan@redhat.com Signed-off-by: Namhyung Kim <namhyung@kernel.org> Signed-off-by: Michael Petlan <mpetlan@redhat.com>
1 parent 8987e6b commit fa963f8

File tree

1 file changed

+0
-13
lines changed

1 file changed

+0
-13
lines changed

tools/perf/tests/shell/stat_bpf_counters_cgrp.sh

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,22 +58,9 @@ check_system_wide_counted()
5858
fi
5959
}
6060

61-
check_cpu_list_counted()
62-
{
63-
check_cpu_list_counted_output=$(perf stat -C 0,1 --bpf-counters --for-each-cgroup ${test_cgroups} -e cpu-clock -x, taskset -c 1 sleep 1 2>&1)
64-
if echo ${check_cpu_list_counted_output} | grep -q -F "<not "; then
65-
echo "Some CPU events are not counted"
66-
if [ "${verbose}" = "1" ]; then
67-
echo ${check_cpu_list_counted_output}
68-
fi
69-
exit 1
70-
fi
71-
}
72-
7361
check_bpf_counter
7462
find_cgroups
7563

7664
check_system_wide_counted
77-
check_cpu_list_counted
7865

7966
exit 0

0 commit comments

Comments
 (0)