Skip to content

Commit fa5a061

Browse files
x-y-zakpm00
authored andcommitted
mm/huge_memory: preserve PG_has_hwpoisoned if a folio is split to >0 order
folio split clears PG_has_hwpoisoned, but the flag should be preserved in after-split folios containing pages with PG_hwpoisoned flag if the folio is split to >0 order folios. Scan all pages in a to-be-split folio to determine which after-split folios need the flag. An alternatives is to change PG_has_hwpoisoned to PG_maybe_hwpoisoned to avoid the scan and set it on all after-split folios, but resulting false positive has undesirable negative impact. To remove false positive, caller of folio_test_has_hwpoisoned() and folio_contain_hwpoisoned_page() needs to do the scan. That might be causing a hassle for current and future callers and more costly than doing the scan in the split code. More details are discussed in [1]. This issue can be exposed via: 1. splitting a has_hwpoisoned folio to >0 order from debugfs interface; 2. truncating part of a has_hwpoisoned folio in truncate_inode_partial_folio(). And later accesses to a hwpoisoned page could be possible due to the missing has_hwpoisoned folio flag. This will lead to MCE errors. Link: https://lore.kernel.org/all/CAHbLzkoOZm0PXxE9qwtF4gKR=cpRXrSrJ9V9Pm2DJexs985q4g@mail.gmail.com/ [1] Link: https://lkml.kernel.org/r/20251023030521.473097-1-ziy@nvidia.com Fixes: c010d47 ("mm: thp: split huge page to any lower order pages") Signed-off-by: Zi Yan <ziy@nvidia.com> Acked-by: David Hildenbrand <david@redhat.com> Reviewed-by: Yang Shi <yang@os.amperecomputing.com> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com> Reviewed-by: Lance Yang <lance.yang@linux.dev> Reviewed-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> Reviewed-by: Wei Yang <richard.weiyang@gmail.com> Cc: Pankaj Raghav <kernel@pankajraghav.com> Cc: Barry Song <baohua@kernel.org> Cc: Dev Jain <dev.jain@arm.com> Cc: Jane Chu <jane.chu@oracle.com> Cc: Liam Howlett <liam.howlett@oracle.com> Cc: Luis Chamberalin <mcgrof@kernel.org> Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: Naoya Horiguchi <nao.horiguchi@gmail.com> Cc: Nico Pache <npache@redhat.com> Cc: Ryan Roberts <ryan.roberts@arm.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent f5548c3 commit fa5a061

File tree

1 file changed

+20
-3
lines changed

1 file changed

+20
-3
lines changed

mm/huge_memory.c

Lines changed: 20 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3263,24 +3263,39 @@ bool can_split_folio(struct folio *folio, int caller_pins, int *pextra_pins)
32633263
caller_pins;
32643264
}
32653265

3266+
static bool page_range_has_hwpoisoned(struct page *page, long nr_pages)
3267+
{
3268+
for (; nr_pages; page++, nr_pages--)
3269+
if (PageHWPoison(page))
3270+
return true;
3271+
return false;
3272+
}
3273+
32663274
/*
32673275
* It splits @folio into @new_order folios and copies the @folio metadata to
32683276
* all the resulting folios.
32693277
*/
32703278
static void __split_folio_to_order(struct folio *folio, int old_order,
32713279
int new_order)
32723280
{
3281+
/* Scan poisoned pages when split a poisoned folio to large folios */
3282+
const bool handle_hwpoison = folio_test_has_hwpoisoned(folio) && new_order;
32733283
long new_nr_pages = 1 << new_order;
32743284
long nr_pages = 1 << old_order;
32753285
long i;
32763286

3287+
folio_clear_has_hwpoisoned(folio);
3288+
3289+
/* Check first new_nr_pages since the loop below skips them */
3290+
if (handle_hwpoison &&
3291+
page_range_has_hwpoisoned(folio_page(folio, 0), new_nr_pages))
3292+
folio_set_has_hwpoisoned(folio);
32773293
/*
32783294
* Skip the first new_nr_pages, since the new folio from them have all
32793295
* the flags from the original folio.
32803296
*/
32813297
for (i = new_nr_pages; i < nr_pages; i += new_nr_pages) {
32823298
struct page *new_head = &folio->page + i;
3283-
32843299
/*
32853300
* Careful: new_folio is not a "real" folio before we cleared PageTail.
32863301
* Don't pass it around before clear_compound_head().
@@ -3322,6 +3337,10 @@ static void __split_folio_to_order(struct folio *folio, int old_order,
33223337
(1L << PG_dirty) |
33233338
LRU_GEN_MASK | LRU_REFS_MASK));
33243339

3340+
if (handle_hwpoison &&
3341+
page_range_has_hwpoisoned(new_head, new_nr_pages))
3342+
folio_set_has_hwpoisoned(new_folio);
3343+
33253344
new_folio->mapping = folio->mapping;
33263345
new_folio->index = folio->index + i;
33273346

@@ -3422,8 +3441,6 @@ static int __split_unmapped_folio(struct folio *folio, int new_order,
34223441
if (folio_test_anon(folio))
34233442
mod_mthp_stat(order, MTHP_STAT_NR_ANON, -1);
34243443

3425-
folio_clear_has_hwpoisoned(folio);
3426-
34273444
/*
34283445
* split to new_order one order at a time. For uniform split,
34293446
* folio is split to new_order directly.

0 commit comments

Comments
 (0)