Skip to content

Commit f8f0ff4

Browse files
author
Charles Mirabile
committed
irqchip/gic-v3-its: Fix over allocation in itt_alloc_pool()
JIRA: https://issues.redhat.com/browse/RHEL-62922 commit bc88d44 Author: Steven Price <steven.price@arm.com> Date: Mon, 21 Oct 2024 11:41:05 +0100 itt_alloc_pool() calls its_alloc_pages_node() to allocate an individual page to add to the pool (for allocations <PAGE_SIZE). However the final argument of its_alloc_pages_node() is the page order not the number of pages. Currently it allocates two pages and leaks the second page. Fix it by passing 0 instead (1 << 0 = 1 page). Fixes: b08e2f4 ("irqchip/gic-v3-its: Share ITS tables with a non-trusted hypervisor") Reported-by: Shanker Donthineni <sdonthineni@nvidia.com> Signed-off-by: Steven Price <steven.price@arm.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/1f6e19c4-1fb9-43ab-a8a2-a465c9cff84b@arm.com Closes: https://lore.kernel.org/r/ed65312a-245c-4fa5-91ad-5d620cab7c6b%40nvidia.com Signed-off-by: Charles Mirabile <cmirabil@redhat.com>
1 parent b11408a commit f8f0ff4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/irqchip/irq-gic-v3-its.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ static void *itt_alloc_pool(int node, int size)
260260
if (addr)
261261
break;
262262

263-
page = its_alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 1);
263+
page = its_alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 0);
264264
if (!page)
265265
break;
266266

0 commit comments

Comments
 (0)