Skip to content

Commit f83db44

Browse files
sm00thviktormalik
authored andcommitted
selftests/bpf: Remove ksyms_weak_lskel test
JIRA: https://issues.redhat.com/browse/RHEL-48593 Upstream status: RHEL-only The test fails to build in Brew (as the build needs to read /proc/kallsysm which has permission 000 in Brew builders) so disable it until Brew builders are fixed. Signed-off-by: Viktor Malik <vmalik@redhat.com> Signed-off-by: Artem Savkov <asavkov@redhat.com>
1 parent d0c50bc commit f83db44

File tree

2 files changed

+1
-32
lines changed

2 files changed

+1
-32
lines changed

tools/testing/selftests/bpf/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -532,7 +532,7 @@ LSKELS := fentry_test.c fexit_test.c fexit_sleep.c atomics.c \
532532
test_ringbuf_n.c test_ringbuf_map_key.c test_ringbuf_write.c
533533

534534
# Generate both light skeleton and libbpf skeleton for these
535-
LSKELS_EXTRA := test_ksyms_module.c test_ksyms_weak.c kfunc_call_test.c \
535+
LSKELS_EXTRA := test_ksyms_module.c kfunc_call_test.c \
536536
kfunc_call_test_subprog.c
537537
SKEL_BLACKLIST += $$(LSKELS)
538538

tools/testing/selftests/bpf/prog_tests/ksyms_btf.c

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#include "test_ksyms_btf.skel.h"
88
#include "test_ksyms_btf_null_check.skel.h"
99
#include "test_ksyms_weak.skel.h"
10-
#include "test_ksyms_weak.lskel.h"
1110
#include "test_ksyms_btf_write_check.skel.h"
1211

1312
static int duration;
@@ -111,33 +110,6 @@ static void test_weak_syms(void)
111110
test_ksyms_weak__destroy(skel);
112111
}
113112

114-
static void test_weak_syms_lskel(void)
115-
{
116-
struct test_ksyms_weak_lskel *skel;
117-
struct test_ksyms_weak_lskel__data *data;
118-
int err;
119-
120-
skel = test_ksyms_weak_lskel__open_and_load();
121-
if (!ASSERT_OK_PTR(skel, "test_ksyms_weak_lskel__open_and_load"))
122-
return;
123-
124-
err = test_ksyms_weak_lskel__attach(skel);
125-
if (!ASSERT_OK(err, "test_ksyms_weak_lskel__attach"))
126-
goto cleanup;
127-
128-
/* trigger tracepoint */
129-
usleep(1);
130-
131-
data = skel->data;
132-
ASSERT_EQ(data->out__existing_typed, 0, "existing typed ksym");
133-
ASSERT_NEQ(data->out__existing_typeless, -1, "existing typeless ksym");
134-
ASSERT_EQ(data->out__non_existent_typeless, 0, "nonexistent typeless ksym");
135-
ASSERT_EQ(data->out__non_existent_typed, 0, "nonexistent typed ksym");
136-
137-
cleanup:
138-
test_ksyms_weak_lskel__destroy(skel);
139-
}
140-
141113
static void test_write_check(bool test_handler1)
142114
{
143115
struct test_ksyms_btf_write_check *skel;
@@ -180,9 +152,6 @@ void test_ksyms_btf(void)
180152
if (test__start_subtest("weak_ksyms"))
181153
test_weak_syms();
182154

183-
if (test__start_subtest("weak_ksyms_lskel"))
184-
test_weak_syms_lskel();
185-
186155
if (test__start_subtest("write_check1"))
187156
test_write_check(true);
188157

0 commit comments

Comments
 (0)