iavf: iavf_suspend(): take RTNL before netdev_lock()

JIRA: https://issues.redhat.com/browse/RHEL-87382

commit dba35a4
Author: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Date:   Fri Apr 4 12:23:16 2025 +0200

    iavf: iavf_suspend(): take RTNL before netdev_lock()

    Fix an obvious violation of lock ordering.
    Jakub's [1] added netdev_lock() call that is wrong ordered wrt RTNL,
    but the Fixes tag points to crit_lock being wrongly placed (by lockdep
    standards).

    Actual reason we got it wrong is dated back to critical section managed by
    pure flag checks, which is with us since the very beginning.

    [1] afc6649 ("eth: iavf: extend the netdev_lock usage")

    Fixes: 5ac49f3 ("iavf: use mutexes for locking of critical sections")
    Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
    Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
    Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>

Signed-off-by: Mohammad Heib <mheib@redhat.com>

Author: mohammadheib

drivers/net/ethernet/intel/iavf/iavf_main.c

@@ -5611,22 +5611,27 @@ static int iavf_suspend(struct device *dev_d)
 {
 	struct net_device *netdev = dev_get_drvdata(dev_d);
 	struct iavf_adapter *adapter = netdev_priv(netdev);
+	bool running;
 
 	netif_device_detach(netdev);
 
+	running = netif_running(netdev);
+	if (running)
+		rtnl_lock();
+
 	netdev_lock(netdev);
 	mutex_lock(&adapter->crit_lock);
 
-	if (netif_running(netdev)) {
-		rtnl_lock();
+	if (running)
 		iavf_down(adapter);
-		rtnl_unlock();
-	}
+
 	iavf_free_misc_irq(adapter);
 	iavf_reset_interrupt_capability(adapter);
 
 	mutex_unlock(&adapter->crit_lock);
 	netdev_unlock(netdev);
+	if (running)
+		rtnl_unlock();
 
 	return 0;
 }