Skip to content

Commit f1811ea

Browse files
author
CKI Backport Bot
committed
net/mdiobus: Fix potential out-of-bounds clause 45 read/write access
JIRA: https://issues.redhat.com/browse/RHEL-102094 CVE: CVE-2025-38110 commit 260388f Author: Jakub Raczynski <j.raczynski@samsung.com> Date: Mon Jun 9 17:31:47 2025 +0200 net/mdiobus: Fix potential out-of-bounds clause 45 read/write access When using publicly available tools like 'mdio-tools' to read/write data from/to network interface and its PHY via C45 (clause 45) mdiobus, there is no verification of parameters passed to the ioctl and it accepts any mdio address. Currently there is support for 32 addresses in kernel via PHY_MAX_ADDR define, but it is possible to pass higher value than that via ioctl. While read/write operation should generally fail in this case, mdiobus provides stats array, where wrong address may allow out-of-bounds read/write. Fix that by adding address verification before C45 read/write operation. While this excludes this access from any statistics, it improves security of read/write operation. Fixes: 4e4aafc ("net: mdio: Add dedicated C45 API to MDIO bus drivers") Signed-off-by: Jakub Raczynski <j.raczynski@samsung.com> Reported-by: Wenjing Shan <wenjing.shan@samsung.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: CKI Backport Bot <cki-ci-bot+cki-gitlab-backport-bot@redhat.com>
1 parent 134517e commit f1811ea

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

drivers/net/phy/mdio_bus.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -979,6 +979,9 @@ int __mdiobus_c45_read(struct mii_bus *bus, int addr, int devad, u32 regnum)
979979

980980
lockdep_assert_held_once(&bus->mdio_lock);
981981

982+
if (addr >= PHY_MAX_ADDR)
983+
return -ENXIO;
984+
982985
if (bus->read_c45)
983986
retval = bus->read_c45(bus, addr, devad, regnum);
984987
else
@@ -1010,6 +1013,9 @@ int __mdiobus_c45_write(struct mii_bus *bus, int addr, int devad, u32 regnum,
10101013

10111014
lockdep_assert_held_once(&bus->mdio_lock);
10121015

1016+
if (addr >= PHY_MAX_ADDR)
1017+
return -ENXIO;
1018+
10131019
if (bus->write_c45)
10141020
err = bus->write_c45(bus, addr, devad, regnum, val);
10151021
else

0 commit comments

Comments
 (0)