Skip to content

Commit f07f91a

Browse files
committed
selftests: net: unify the Makefile formats
We get a significant number of conflicts between net and net-next because of selftests Makefile changes. People tend to append new test cases at the end of the Makefile when there's no clear sort order. Sort all networking selftests Makefiles, use the following format: VAR_NAME := \ entry1 \ entry2 \ entry3 \ # end of VAR_NAME Some Makefiles are already pretty close to this. Acked-by: Antonio Quartulli <antonio@openvpn.net> Acked-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Acked-by: Allison Henderson <allison.henderson@oracle.com> Reviewed-by: Petr Machata <petrm@nvidia.com> Link: https://patch.msgid.link/20251003210127.1021918-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 2aa74c6 commit f07f91a

File tree

17 files changed

+383
-242
lines changed

17 files changed

+383
-242
lines changed

tools/testing/selftests/drivers/net/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ TEST_GEN_FILES := \
1010
# end of TEST_GEN_FILES
1111

1212
TEST_PROGS := \
13+
hds.py \
1314
napi_id.py \
1415
napi_threaded.py \
1516
netcons_basic.sh \
@@ -21,9 +22,8 @@ TEST_PROGS := \
2122
ping.py \
2223
psp.py \
2324
queues.py \
24-
stats.py \
2525
shaper.py \
26-
hds.py \
26+
stats.py \
2727
xdp.py \
2828
# end of TEST_PROGS
2929

tools/testing/selftests/drivers/net/bonding/Makefile

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,27 @@
44
TEST_PROGS := \
55
bond-arp-interval-causes-panic.sh \
66
bond-break-lacpdu-tx.sh \
7+
bond-eth-type-change.sh \
78
bond-lladdr-target.sh \
9+
bond_ipsec_offload.sh \
10+
bond_lacp_prio.sh \
11+
bond_macvlan_ipvlan.sh \
12+
bond_options.sh \
13+
bond_passive_lacp.sh \
814
dev_addr_lists.sh \
915
mode-1-recovery-updelay.sh \
1016
mode-2-recovery-updelay.sh \
11-
bond_options.sh \
12-
bond-eth-type-change.sh \
13-
bond_macvlan_ipvlan.sh \
14-
bond_passive_lacp.sh \
15-
bond_lacp_prio.sh
16-
bond_ipsec_offload.sh
17+
# end of TEST_PROGS
1718

1819
TEST_FILES := \
19-
lag_lib.sh \
2020
bond_topo_2d1c.sh \
21-
bond_topo_3d1c.sh
21+
bond_topo_3d1c.sh \
22+
lag_lib.sh \
23+
# end of TEST_FILES
2224

2325
TEST_INCLUDES := \
26+
../../../net/lib.sh \
2427
../../../net/forwarding/lib.sh \
25-
../../../net/lib.sh
28+
# end of TEST_INCLUDES
2629

2730
include ../../../lib.mk

tools/testing/selftests/drivers/net/dsa/Makefile

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# SPDX-License-Identifier: GPL-2.0+ OR MIT
22

3-
TEST_PROGS = bridge_locked_port.sh \
3+
TEST_PROGS := \
4+
bridge_locked_port.sh \
45
bridge_mdb.sh \
56
bridge_mld.sh \
67
bridge_vlan_aware.sh \
@@ -9,11 +10,13 @@ TEST_PROGS = bridge_locked_port.sh \
910
local_termination.sh \
1011
no_forwarding.sh \
1112
tc_actions.sh \
12-
test_bridge_fdb_stress.sh
13+
test_bridge_fdb_stress.sh \
14+
# end of TEST_PROGS
1315

1416
TEST_FILES := \
17+
forwarding.config \
1518
run_net_forwarding_test.sh \
16-
forwarding.config
19+
# end of TEST_FILES
1720

1821
TEST_INCLUDES := \
1922
../../../net/forwarding/bridge_locked_port.sh \
@@ -27,6 +30,7 @@ TEST_INCLUDES := \
2730
../../../net/forwarding/no_forwarding.sh \
2831
../../../net/forwarding/tc_actions.sh \
2932
../../../net/forwarding/tc_common.sh \
30-
../../../net/lib.sh
33+
../../../net/lib.sh \
34+
# end of TEST_INCLUDES
3135

3236
include ../../../lib.mk

tools/testing/selftests/drivers/net/hw/Makefile

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ TEST_FILES := \
3232
TEST_INCLUDES := \
3333
$(wildcard lib/py/*.py ../lib/py/*.py) \
3434
../../../net/lib.sh \
35-
../../../net/forwarding/lib.sh \
3635
../../../net/forwarding/ipip_lib.sh \
36+
../../../net/forwarding/lib.sh \
3737
../../../net/forwarding/tc_common.sh \
3838
#
3939

@@ -45,7 +45,11 @@ TEST_GEN_FILES += $(patsubst %.c,%.o,$(wildcard *.bpf.c))
4545
include ../../../lib.mk
4646

4747
# YNL build
48-
YNL_GENS := ethtool netdev
48+
YNL_GENS := \
49+
ethtool \
50+
netdev \
51+
# end of YNL_GENS
52+
4953
include ../../../net/ynl.mk
5054

5155
include ../../../net/bpf.mk

tools/testing/selftests/drivers/net/netdevsim/Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# SPDX-License-Identifier: GPL-2.0+ OR MIT
22

3-
TEST_PROGS = devlink.sh \
3+
TEST_PROGS := \
4+
devlink.sh \
45
devlink_in_netns.sh \
56
devlink_trap.sh \
67
ethtool-coalesce.sh \
@@ -17,5 +18,6 @@ TEST_PROGS = devlink.sh \
1718
psample.sh \
1819
tc-mq-visibility.sh \
1920
udp_tunnel_nic.sh \
21+
# end of TEST_PROGS
2022

2123
include ../../../lib.mk
Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,18 @@
11
# SPDX-License-Identifier: GPL-2.0
22
# Makefile for net selftests
33

4-
TEST_PROGS := dev_addr_lists.sh propagation.sh options.sh
4+
TEST_PROGS := \
5+
dev_addr_lists.sh \
6+
options.sh \
7+
propagation.sh \
8+
# end of TEST_PROGS
59

610
TEST_INCLUDES := \
711
../bonding/lag_lib.sh \
812
../../../net/forwarding/lib.sh \
9-
../../../net/lib.sh \
1013
../../../net/in_netns.sh \
11-
../../../net/lib/sh/defer.sh
14+
../../../net/lib.sh \
15+
../../../net/lib/sh/defer.sh \
16+
# end of TEST_INCLUDES
1217

1318
include ../../../lib.mk
Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,12 @@
11
# SPDX-License-Identifier: GPL-2.0+ OR MIT
22

3-
TEST_PROGS = basic_features.sh \
4-
#
3+
TEST_PROGS = basic_features.sh
54

6-
TEST_FILES = \
7-
virtio_net_common.sh \
8-
#
5+
TEST_FILES = virtio_net_common.sh
96

107
TEST_INCLUDES = \
11-
../../../net/forwarding/lib.sh \
12-
../../../net/lib.sh \
13-
#
8+
../../../net/forwarding/lib.sh \
9+
../../../net/lib.sh \
10+
# end of TEST_INCLUDES
1411

1512
include ../../../lib.mk

0 commit comments

Comments
 (0)