Skip to content

Commit ec462f5

Browse files
author
Ming Lei
committed
scsi: sd: Only print updates to permanent stream count
JIRA: https://issues.redhat.com/browse/RHEL-79409 commit 961990e Author: John Garry <john.g.garry@oracle.com> Date: Fri Apr 12 09:44:07 2024 +0000 scsi: sd: Only print updates to permanent stream count Just rescanning a partition causes a print similar to the following to appear: [ 1.484964] sd 0:0:0:0: [sda] permanent stream count = 5 This is bothersome, so only print this message for an update. Fixes: 4f53138 ("scsi: sd: Translate data lifetime information") Signed-off-by: John Garry <john.g.garry@oracle.com> Link: https://lore.kernel.org/r/20240412094407.496251-1-john.g.garry@oracle.com Reviewed-by: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Ming Lei <ming.lei@redhat.com>
1 parent 7b229ad commit ec462f5

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/scsi/sd.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3243,6 +3243,7 @@ static void sd_read_io_hints(struct scsi_disk *sdkp, unsigned char *buffer)
32433243
{
32443244
struct scsi_device *sdp = sdkp->device;
32453245
const struct scsi_io_group_descriptor *desc, *start, *end;
3246+
u16 permanent_stream_count_old;
32463247
struct scsi_sense_hdr sshdr;
32473248
struct scsi_mode_data data;
32483249
int res;
@@ -3263,12 +3264,13 @@ static void sd_read_io_hints(struct scsi_disk *sdkp, unsigned char *buffer)
32633264
for (desc = start; desc < end; desc++)
32643265
if (!desc->st_enble || !sd_is_perm_stream(sdkp, desc - start))
32653266
break;
3267+
permanent_stream_count_old = sdkp->permanent_stream_count;
32663268
sdkp->permanent_stream_count = desc - start;
32673269
if (sdkp->rscs && sdkp->permanent_stream_count < 2)
32683270
sd_printk(KERN_INFO, sdkp,
32693271
"Unexpected: RSCS has been set and the permanent stream count is %u\n",
32703272
sdkp->permanent_stream_count);
3271-
else if (sdkp->permanent_stream_count)
3273+
else if (sdkp->permanent_stream_count != permanent_stream_count_old)
32723274
sd_printk(KERN_INFO, sdkp, "permanent stream count = %d\n",
32733275
sdkp->permanent_stream_count);
32743276
}

0 commit comments

Comments
 (0)