Skip to content

Commit e7285b1

Browse files
JeffMoyerJeff Moyer
authored andcommitted
libnvdimm: Remove unused nd_attach_ndns
JIRA: https://issues.redhat.com/browse/RHEL-96846 commit 2318fa8 Author: Dr. David Alan Gilbert <linux@treblig.org> Date: Thu Feb 20 00:45:38 2025 +0000 libnvdimm: Remove unused nd_attach_ndns nd_attach_ndns() hasn't been used since 2017's commit 452bae0 ("libnvdimm: fix nvdimm_bus_lock() vs device_lock() ordering") Remove it. Note the __ version is still used and has been left. Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org> Reviewed-by: Ira Weiny <ira.weiny@intel.com> Link: https://patch.msgid.link/20250220004538.84585-3-linux@treblig.org Signed-off-by: Ira Weiny <ira.weiny@intel.com> Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
1 parent 75bca4a commit e7285b1

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

drivers/nvdimm/claim.c

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -56,17 +56,6 @@ bool __nd_attach_ndns(struct device *dev, struct nd_namespace_common *attach,
5656
return true;
5757
}
5858

59-
bool nd_attach_ndns(struct device *dev, struct nd_namespace_common *attach,
60-
struct nd_namespace_common **_ndns)
61-
{
62-
bool claimed;
63-
64-
nvdimm_bus_lock(&attach->dev);
65-
claimed = __nd_attach_ndns(dev, attach, _ndns);
66-
nvdimm_bus_unlock(&attach->dev);
67-
return claimed;
68-
}
69-
7059
static bool is_idle(struct device *dev, struct nd_namespace_common *ndns)
7160
{
7261
struct nd_region *nd_region = to_nd_region(dev->parent);

drivers/nvdimm/nd-core.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,6 @@ void get_ndd(struct nvdimm_drvdata *ndd);
136136
resource_size_t __nvdimm_namespace_capacity(struct nd_namespace_common *ndns);
137137
void nd_detach_ndns(struct device *dev, struct nd_namespace_common **_ndns);
138138
void __nd_detach_ndns(struct device *dev, struct nd_namespace_common **_ndns);
139-
bool nd_attach_ndns(struct device *dev, struct nd_namespace_common *attach,
140-
struct nd_namespace_common **_ndns);
141139
bool __nd_attach_ndns(struct device *dev, struct nd_namespace_common *attach,
142140
struct nd_namespace_common **_ndns);
143141
ssize_t nd_namespace_store(struct device *dev,

0 commit comments

Comments
 (0)