Skip to content

Commit e4a0bfc

Browse files
nvme-pci: fix queue unquiesce check on slot_reset
JIRA: https://issues.redhat.com/browse/RHEL-96225 A zero return means the reset was successfully scheduled. We don't want to unquiesce the queues while the reset_work is pending, as that will just flush out requeued requests to a failed completion. Fixes: 71a5bb1 ("nvme: ensure disabling pairs with unquiesce") Reported-by: Dhankaran Singh Ajravat <dhankaran@meta.com> Signed-off-by: Keith Busch <kbusch@kernel.org> Signed-off-by: Christoph Hellwig <hch@lst.de> (cherry picked from commit a754012) Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
1 parent bc09a1a commit e4a0bfc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/nvme/host/pci.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3459,7 +3459,7 @@ static pci_ers_result_t nvme_slot_reset(struct pci_dev *pdev)
34593459

34603460
dev_info(dev->ctrl.device, "restart after slot reset\n");
34613461
pci_restore_state(pdev);
3462-
if (!nvme_try_sched_reset(&dev->ctrl))
3462+
if (nvme_try_sched_reset(&dev->ctrl))
34633463
nvme_unquiesce_io_queues(&dev->ctrl);
34643464
return PCI_ERS_RESULT_RECOVERED;
34653465
}

0 commit comments

Comments
 (0)