Skip to content

Commit e400392

Browse files
committed
net: usb: cdc_ether: don't spew notifications
JIRA: https://issues.redhat.com/browse/RHEL-52777 commit 2d5c9dd Author: zhangxiangqian <zhangxiangqian@kylinos.cn> Date: Thu Aug 8 17:39:45 2024 +0800 net: usb: cdc_ether: don't spew notifications The usbnet_link_change function is not called, if the link has not changed. ... [16913.807393][ 3] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 12 may have been dropped [16913.822266][ 2] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 12 may have been dropped [16913.826296][ 2] cdc_ether 1-2:2.0 enx00e0995fd1ac: kevent 11 may have been dropped ... kevent 11 is scheduled too frequently and may affect other event schedules. Signed-off-by: zhangxiangqian <zhangxiangqian@kylinos.cn> Acked-by: Oliver Neukum <oneukum@suse.com> Link: https://patch.msgid.link/1723109985-11996-1-git-send-email-zhangxiangqian@kylinos.cn Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
1 parent 2932f4f commit e400392

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/usb/cdc_ether.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,8 @@ void usbnet_cdc_status(struct usbnet *dev, struct urb *urb)
418418
case USB_CDC_NOTIFY_NETWORK_CONNECTION:
419419
netif_dbg(dev, timer, dev->net, "CDC: carrier %s\n",
420420
event->wValue ? "on" : "off");
421-
usbnet_link_change(dev, !!event->wValue, 0);
421+
if (netif_carrier_ok(dev->net) != !!event->wValue)
422+
usbnet_link_change(dev, !!event->wValue, 0);
422423
break;
423424
case USB_CDC_NOTIFY_SPEED_CHANGE: /* tx/rx rates */
424425
netif_dbg(dev, timer, dev->net, "CDC: speed change (len %d)\n",

0 commit comments

Comments
 (0)